Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: runtime/lib/integers.cc

Issue 1900863004: VM: Remove _leftShiftWithMask32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/bigint.dart ('k') | runtime/lib/integers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers.cc
diff --git a/runtime/lib/integers.cc b/runtime/lib/integers.cc
index 3874ae5ad9f1c51f4b2ac0ec59f571e32aa7489f..a1aa3bd3d3b1ea63ad0b5fa1957660fd8d2e4227 100644
--- a/runtime/lib/integers.cc
+++ b/runtime/lib/integers.cc
@@ -290,28 +290,6 @@ static RawInteger* ShiftOperationHelper(Token::Kind kind,
}
-DEFINE_NATIVE_ENTRY(Integer_leftShiftWithMask32, 3) {
- const Integer& value = Integer::CheckedHandle(arguments->NativeArgAt(0));
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, shift_count, arguments->NativeArgAt(1));
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, mask, arguments->NativeArgAt(2));
- ASSERT(CheckInteger(value));
- ASSERT(CheckInteger(shift_count));
- ASSERT(CheckInteger(mask));
- if (!shift_count.IsSmi()) {
- // Shift count is too large..
- const Instance& exception =
- Instance::Handle(isolate->object_store()->out_of_memory());
- Exceptions::Throw(thread, exception);
- }
- const Smi& smi_shift_count = Smi::Cast(shift_count);
- const Integer& shift_result = Integer::Handle(
- ShiftOperationHelper(Token::kSHL, value, smi_shift_count));
- const Integer& result =
- Integer::Handle(shift_result.BitOp(Token::kBIT_AND, mask));
- return result.AsValidInteger();
-}
-
-
DEFINE_NATIVE_ENTRY(Smi_shrFromInt, 2) {
const Smi& amount = Smi::CheckedHandle(arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, value, arguments->NativeArgAt(1));
« no previous file with comments | « runtime/lib/bigint.dart ('k') | runtime/lib/integers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698