Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1900863002: Reapply "- Use a hash table to canonicalize instances/arrays to avoid having to iterate over a line… (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "- Use a hash table to canonicalize instances/arrays to avoid having to iterate over a linear list and search for canonical instances." - Rehash constants table during tree-shaking. - Rehash constants table on snapshot load. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/f731dd061545384647fd730abe66eb2af5c7ba7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -128 lines) Patch
M runtime/lib/integers.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M runtime/vm/dart_entry.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M runtime/vm/object.h View 15 chunks +46 lines, -12 lines 0 comments Download
M runtime/vm/object.cc View 21 chunks +200 lines, -80 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-18 22:11:18 UTC) #2
regis
LGTM
4 years, 8 months ago (2016-04-18 22:25:39 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-18 23:46:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f731dd061545384647fd730abe66eb2af5c7ba7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698