Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1900843003: Fix a bug that mime type isn't passed when checking Codec capabilities (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
Tima Vaisburd, ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that mime type isn't passed when checking Codec capabilities Chrome is passing wrong MIME type when checking vp8/9 codec capability. We should use video/x-vnd.on2.vp8, but using vp8 instead. This is a simple fix so that it can be easily merged. An improvement of the CL can be found at https://codereview.chromium.org/1897003002 TBR=timav@chromium.org BUG=603162 Committed: https://crrev.com/a4631e6a7033e606cd29d662dbb040e8e1ceb4fe Cr-Commit-Position: refs/heads/master@{#388066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/base/android/media_codec_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900843003/1
4 years, 8 months ago (2016-04-18 21:52:18 UTC) #2
ddorwin
lgtm
4 years, 8 months ago (2016-04-18 21:59:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:06:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4631e6a7033e606cd29d662dbb040e8e1ceb4fe Cr-Commit-Position: refs/heads/master@{#388066}
4 years, 8 months ago (2016-04-18 23:08:33 UTC) #7
mikecase (-- gone --)
4 years, 8 months ago (2016-04-19 22:49:48 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1898353002/ by mikecase@chromium.org.

The reason for reverting is: CL cause of crbug/604917
Locally reverted this CL to confirm.

Powered by Google App Engine
This is Rietveld 408576698