Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/s390/assembler-s390-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ppc/assembler-ppc-inl.h ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 } else if (IsInternalReferenceEncoded(rmode_)) { 305 } else if (IsInternalReferenceEncoded(rmode_)) {
306 // mov sequence 306 // mov sequence
307 // Currently used only by deserializer, no need to flush. 307 // Currently used only by deserializer, no need to flush.
308 Assembler::set_target_address_at(isolate_, pc_, host_, NULL, 308 Assembler::set_target_address_at(isolate_, pc_, host_, NULL,
309 SKIP_ICACHE_FLUSH); 309 SKIP_ICACHE_FLUSH);
310 } else { 310 } else {
311 Assembler::set_target_address_at(isolate_, pc_, host_, NULL); 311 Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
312 } 312 }
313 } 313 }
314 314
315 template <typename ObjectVisitor>
315 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 316 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
316 RelocInfo::Mode mode = rmode(); 317 RelocInfo::Mode mode = rmode();
317 if (mode == RelocInfo::EMBEDDED_OBJECT) { 318 if (mode == RelocInfo::EMBEDDED_OBJECT) {
318 visitor->VisitEmbeddedPointer(this); 319 visitor->VisitEmbeddedPointer(this);
319 } else if (RelocInfo::IsCodeTarget(mode)) { 320 } else if (RelocInfo::IsCodeTarget(mode)) {
320 visitor->VisitCodeTarget(this); 321 visitor->VisitCodeTarget(this);
321 } else if (mode == RelocInfo::CELL) { 322 } else if (mode == RelocInfo::CELL) {
322 visitor->VisitCell(this); 323 visitor->VisitCell(this);
323 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 324 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
324 visitor->VisitExternalReference(this); 325 visitor->VisitExternalReference(this);
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 } 585 }
585 #endif 586 #endif
586 } 587 }
587 if (!patched) UNREACHABLE(); 588 if (!patched) UNREACHABLE();
588 } 589 }
589 590
590 } // namespace internal 591 } // namespace internal
591 } // namespace v8 592 } // namespace v8
592 593
593 #endif // V8_S390_ASSEMBLER_S390_INL_H_ 594 #endif // V8_S390_ASSEMBLER_S390_INL_H_
OLDNEW
« no previous file with comments | « src/ppc/assembler-ppc-inl.h ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698