Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: src/mips64/assembler-mips64-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/ppc/assembler-ppc-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_)); 355 IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_));
356 if (IsInternalReference(rmode_)) { 356 if (IsInternalReference(rmode_)) {
357 Memory::Address_at(pc_) = NULL; 357 Memory::Address_at(pc_) = NULL;
358 } else if (IsInternalReferenceEncoded(rmode_)) { 358 } else if (IsInternalReferenceEncoded(rmode_)) {
359 Assembler::set_target_internal_reference_encoded_at(pc_, nullptr); 359 Assembler::set_target_internal_reference_encoded_at(pc_, nullptr);
360 } else { 360 } else {
361 Assembler::set_target_address_at(isolate_, pc_, host_, NULL); 361 Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
362 } 362 }
363 } 363 }
364 364
365 365 template <typename ObjectVisitor>
366 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 366 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
367 RelocInfo::Mode mode = rmode(); 367 RelocInfo::Mode mode = rmode();
368 if (mode == RelocInfo::EMBEDDED_OBJECT) { 368 if (mode == RelocInfo::EMBEDDED_OBJECT) {
369 visitor->VisitEmbeddedPointer(this); 369 visitor->VisitEmbeddedPointer(this);
370 } else if (RelocInfo::IsCodeTarget(mode)) { 370 } else if (RelocInfo::IsCodeTarget(mode)) {
371 visitor->VisitCodeTarget(this); 371 visitor->VisitCodeTarget(this);
372 } else if (mode == RelocInfo::CELL) { 372 } else if (mode == RelocInfo::CELL) {
373 visitor->VisitCell(this); 373 visitor->VisitCell(this);
374 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 374 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
375 visitor->VisitExternalReference(this); 375 visitor->VisitExternalReference(this);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 void Assembler::emit(uint64_t data) { 483 void Assembler::emit(uint64_t data) {
484 CheckForEmitInForbiddenSlot(); 484 CheckForEmitInForbiddenSlot();
485 EmitHelper(data); 485 EmitHelper(data);
486 } 486 }
487 487
488 488
489 } // namespace internal 489 } // namespace internal
490 } // namespace v8 490 } // namespace v8
491 491
492 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 492 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/ppc/assembler-ppc-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698