Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/mips/assembler-mips-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_)); 373 IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_));
374 if (IsInternalReference(rmode_)) { 374 if (IsInternalReference(rmode_)) {
375 Memory::Address_at(pc_) = NULL; 375 Memory::Address_at(pc_) = NULL;
376 } else if (IsInternalReferenceEncoded(rmode_)) { 376 } else if (IsInternalReferenceEncoded(rmode_)) {
377 Assembler::set_target_internal_reference_encoded_at(pc_, nullptr); 377 Assembler::set_target_internal_reference_encoded_at(pc_, nullptr);
378 } else { 378 } else {
379 Assembler::set_target_address_at(isolate_, pc_, host_, NULL); 379 Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
380 } 380 }
381 } 381 }
382 382
383 383 template <typename ObjectVisitor>
384 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 384 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
385 RelocInfo::Mode mode = rmode(); 385 RelocInfo::Mode mode = rmode();
386 if (mode == RelocInfo::EMBEDDED_OBJECT) { 386 if (mode == RelocInfo::EMBEDDED_OBJECT) {
387 visitor->VisitEmbeddedPointer(this); 387 visitor->VisitEmbeddedPointer(this);
388 } else if (RelocInfo::IsCodeTarget(mode)) { 388 } else if (RelocInfo::IsCodeTarget(mode)) {
389 visitor->VisitCodeTarget(this); 389 visitor->VisitCodeTarget(this);
390 } else if (mode == RelocInfo::CELL) { 390 } else if (mode == RelocInfo::CELL) {
391 visitor->VisitCell(this); 391 visitor->VisitCell(this);
392 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 392 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
393 visitor->VisitExternalReference(this); 393 visitor->VisitExternalReference(this);
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 CheckBuffer(); 495 CheckBuffer();
496 } 496 }
497 EmitHelper(x, is_compact_branch); 497 EmitHelper(x, is_compact_branch);
498 } 498 }
499 499
500 500
501 } // namespace internal 501 } // namespace internal
502 } // namespace v8 502 } // namespace v8
503 503
504 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 504 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/mips64/assembler-mips64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698