Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: src/ia32/assembler-ia32-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 Memory::Address_at(pc_) = NULL; 276 Memory::Address_at(pc_) = NULL;
277 } else if (IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)) { 277 } else if (IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)) {
278 // Effectively write zero into the relocation. 278 // Effectively write zero into the relocation.
279 Assembler::set_target_address_at(isolate_, pc_, host_, 279 Assembler::set_target_address_at(isolate_, pc_, host_,
280 pc_ + sizeof(int32_t)); 280 pc_ + sizeof(int32_t));
281 } else { 281 } else {
282 UNREACHABLE(); 282 UNREACHABLE();
283 } 283 }
284 } 284 }
285 285
286 286 template <typename ObjectVisitor>
287 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 287 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
288 RelocInfo::Mode mode = rmode(); 288 RelocInfo::Mode mode = rmode();
289 if (mode == RelocInfo::EMBEDDED_OBJECT) { 289 if (mode == RelocInfo::EMBEDDED_OBJECT) {
290 visitor->VisitEmbeddedPointer(this); 290 visitor->VisitEmbeddedPointer(this);
291 Assembler::FlushICache(isolate, pc_, sizeof(Address)); 291 Assembler::FlushICache(isolate, pc_, sizeof(Address));
292 } else if (RelocInfo::IsCodeTarget(mode)) { 292 } else if (RelocInfo::IsCodeTarget(mode)) {
293 visitor->VisitCodeTarget(this); 293 visitor->VisitCodeTarget(this);
294 } else if (mode == RelocInfo::CELL) { 294 } else if (mode == RelocInfo::CELL) {
295 visitor->VisitCell(this); 295 visitor->VisitCell(this);
296 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 296 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 573
574 Operand::Operand(Immediate imm) { 574 Operand::Operand(Immediate imm) {
575 // [disp/r] 575 // [disp/r]
576 set_modrm(0, ebp); 576 set_modrm(0, ebp);
577 set_dispr(imm.x_, imm.rmode_); 577 set_dispr(imm.x_, imm.rmode_);
578 } 578 }
579 } // namespace internal 579 } // namespace internal
580 } // namespace v8 580 } // namespace v8
581 581
582 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_ 582 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698