Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: src/arm/assembler-arm-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 DCHECK(IsEmbeddedObject(rmode_) || IsCodeTarget(rmode_) || 269 DCHECK(IsEmbeddedObject(rmode_) || IsCodeTarget(rmode_) ||
270 IsRuntimeEntry(rmode_) || IsExternalReference(rmode_) || 270 IsRuntimeEntry(rmode_) || IsExternalReference(rmode_) ||
271 IsInternalReference(rmode_)); 271 IsInternalReference(rmode_));
272 if (IsInternalReference(rmode_)) { 272 if (IsInternalReference(rmode_)) {
273 Memory::Address_at(pc_) = NULL; 273 Memory::Address_at(pc_) = NULL;
274 } else { 274 } else {
275 Assembler::set_target_address_at(isolate_, pc_, host_, NULL); 275 Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
276 } 276 }
277 } 277 }
278 278
279 279 template <typename ObjectVisitor>
280 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 280 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
281 RelocInfo::Mode mode = rmode(); 281 RelocInfo::Mode mode = rmode();
282 if (mode == RelocInfo::EMBEDDED_OBJECT) { 282 if (mode == RelocInfo::EMBEDDED_OBJECT) {
283 visitor->VisitEmbeddedPointer(this); 283 visitor->VisitEmbeddedPointer(this);
284 } else if (RelocInfo::IsCodeTarget(mode)) { 284 } else if (RelocInfo::IsCodeTarget(mode)) {
285 visitor->VisitCodeTarget(this); 285 visitor->VisitCodeTarget(this);
286 } else if (mode == RelocInfo::CELL) { 286 } else if (mode == RelocInfo::CELL) {
287 visitor->VisitCell(this); 287 visitor->VisitCell(this);
288 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 288 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
289 visitor->VisitExternalReference(this); 289 visitor->VisitExternalReference(this);
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 Assembler::FlushICache(isolate, pc, 4 * kInstrSize); 619 Assembler::FlushICache(isolate, pc, 4 * kInstrSize);
620 } 620 }
621 } 621 }
622 } 622 }
623 623
624 624
625 } // namespace internal 625 } // namespace internal
626 } // namespace v8 626 } // namespace v8
627 627
628 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_ 628 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698