[ios] Do not allow loading chrome:// URLs from regular http/https pages.

[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086
Committed: https://crrev.com/4998fbe285b9c857b454b70a2bfeda562a92c3ae
Cr-Commit-Position: refs/heads/master@{#388217}

[Eugene But (OOO till 7-30), 2016-04-18 18:44:59]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org, palmer@chromium.org

[palmer, 2016-04-18 19:02:12]

palmer@chromium.org changed reviewers:
+ rsesek@chromium.org

[palmer, 2016-04-18 19:02:13]

LGTM, but I am not the world's most expert iOS/Objective-C person. Adding
rsesek. :)

[Robert Sesek, 2016-04-18 19:23:00]

Code LGTM, but is the BUG= correct? Also, this is probably code worth having
tests for.

[Eugene But (OOO till 7-30), 2016-04-18 20:07:23]

Description was changed from

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=603634
==========

to

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086
==========

[Eugene But (OOO till 7-30), 2016-04-18 20:08:08]

On 2016/04/18 19:23:00, Robert Sesek wrote:
> Code LGTM, but is the BUG= correct? Also, this is probably code worth having
> tests for.
Sorry, updated the bug. We do have a donwstream test for this:
https://chromereviews.googleplex.com/406047013/

[Jackie Quinn, 2016-04-19 13:41:51]

lgtm

[Eugene But (OOO till 7-30), 2016-04-19 14:00:56]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-04-19 14:01:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900783003/20001

[commit-bot: I haz the power, 2016-04-19 14:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 14:08:37]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Eugene But (OOO till 7-30), 2016-04-19 15:40:19]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-04-19 15:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
rsesek@chromium.org, jyquinn@chromium.org
Link to the patchset: https://codereview.chromium.org/1900783003/#ps40001
(title: "s/self.documentURL/_documentURL.")

[commit-bot: I haz the power, 2016-04-19 15:40:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900783003/40001

[commit-bot: I haz the power, 2016-04-19 16:15:02]

Description was changed from

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086
==========

to

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086
==========

[commit-bot: I haz the power, 2016-04-19 16:15:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:12:37]

Description was changed from

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086
==========

to

==========
[ios] Do not allow loading chrome:// URLs from regular http/https pages.

BUG=604086

Committed: https://crrev.com/4998fbe285b9c857b454b70a2bfeda562a92c3ae
Cr-Commit-Position: refs/heads/master@{#388217}
==========

[commit-bot: I haz the power, 2016-04-22 19:12:38]

Patchset 3 (id:??) landed as
https://crrev.com/4998fbe285b9c857b454b70a2bfeda562a92c3ae
Cr-Commit-Position: refs/heads/master@{#388217}