Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1900773002: Update android toolchain variable to point to root dir and not the bin (Closed)

Created:
4 years, 8 months ago by djsollen
Modified:
4 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M platform_tools/android/bin/android_gdb_app View 2 chunks +2 lines, -2 lines 0 comments Download
M platform_tools/android/bin/android_gdb_native View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/utils/setup_toolchain.sh View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
djsollen
4 years, 8 months ago (2016-04-18 17:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900773002/1
4 years, 8 months ago (2016-04-18 17:51:07 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-18 17:51:08 UTC) #6
scroggo
lgtm
4 years, 8 months ago (2016-04-18 17:54:16 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:01:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/382949db14cb38ffbc5b1e15a0f56bb7d4e8f7d0

Powered by Google App Engine
This is Rietveld 408576698