Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1900743003: [compiler] Remove obsolete guard in MarkForOptimization. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
titzer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete guard in MarkForOptimization. The guard in JSFunction::MarkForOptimization checking whether a function is being debugged is overly protective. The compilation pipeline will bailout itself in that circumstance. Having the runtime behave similar makes sure the debugger observes a situation closer to reality. R=yangguo@chromium.org Committed: https://crrev.com/1705b7de4f22fbd7492c27ccc8fa25348fbc945d Cr-Commit-Position: refs/heads/master@{#35625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
titzer
Drive-by lgtm, as you know I hate asserts :)
4 years, 8 months ago (2016-04-19 13:28:03 UTC) #2
Michael Starzinger
Yang: PTAL.
4 years, 8 months ago (2016-04-19 13:40:23 UTC) #5
Yang
On 2016/04/19 13:40:23, Michael Starzinger wrote: > Yang: PTAL. lgtm.
4 years, 8 months ago (2016-04-19 14:36:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900743003/1
4 years, 8 months ago (2016-04-19 14:39:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 14:42:08 UTC) #10
nodir1
4 years, 8 months ago (2016-04-22 18:42:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1705b7de4f22fbd7492c27ccc8fa25348fbc945d
Cr-Commit-Position: refs/heads/master@{#35625}

Powered by Google App Engine
This is Rietveld 408576698