Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 1900723002: Revert of cc: Add a main thread LayerListIterator (Closed)

Created:
4 years, 8 months ago by sunxd
Modified:
4 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add a main thread LayerListIterator (patchset #6 id:100001 of https://codereview.chromium.org/1887703002/ ) Reason for revert: Possible failure to android_clang_buildbot (https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Clang%20Builder%20(dbg)/builds/78715/steps/compile/logs/stdio) Original issue's description: > cc: Add a main thread LayerListIterator > > Make LayerListIterator a template class for Layer and LayerImpl. > > Add tests for LayerListIterator<Layer>. > > Noted that cc_unittests: > LayerTreeHostCopyRequestTestLostOutputSurface. > RunMultiThread_DirectRenderer might be flacky. > > BUG=603181 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 > Cr-Commit-Position: refs/heads/master@{#387422} > > Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 > Cr-Commit-Position: refs/heads/master@{#387908} TBR=ajuma@chromium.org,vollick@chromium.org,jaydasika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603181 Committed: https://crrev.com/3cbb6e9a48bd1579069eabcc7d3cc2ff9ef21cad Cr-Commit-Position: refs/heads/master@{#387929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -285 lines) Patch
M cc/layers/layer_list_iterator.h View 2 chunks +10 lines, -15 lines 0 comments Download
M cc/layers/layer_list_iterator.cc View 2 chunks +31 lines, -44 lines 0 comments Download
M cc/layers/layer_list_iterator_unittest.cc View 6 chunks +9 lines, -186 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sunxd
Created Revert of cc: Add a main thread LayerListIterator
4 years, 8 months ago (2016-04-18 17:10:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900723002/1
4 years, 8 months ago (2016-04-18 17:11:17 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-18 17:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900723002/1
4 years, 8 months ago (2016-04-18 17:15:40 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-18 17:15:42 UTC) #8
mikecase (-- gone --)
lgtm
4 years, 8 months ago (2016-04-18 17:16:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900723002/1
4 years, 8 months ago (2016-04-18 17:17:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 17:18:07 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:19:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cbb6e9a48bd1579069eabcc7d3cc2ff9ef21cad
Cr-Commit-Position: refs/heads/master@{#387929}

Powered by Google App Engine
This is Rietveld 408576698