Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1900633002: cc: remove call to SkImageFilter::canFilterImageGPU(). (Closed)

Created:
4 years, 8 months ago by Stephen White
Modified:
4 years, 8 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: remove call to SkImageFilter::canFilterImageGPU(). This function is going away in Skia, and probably doesn't do what the caller (added in https://codereview.chromium.org/21154002/) intended anyway: it means that the filter implements filterImageGPU(), an explicit GPU path which draws texture-to-texture. The filter may return false for canFilterImageGPU(), and still happily run on the GPU using generic Skia calls in onFilterImage(). Anyway, all of this confusion will soon be removed, along with these functions. R=ajuma@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/86649e2861205f8ce4d7099cb83b1cd16648dfa8 Cr-Commit-Position: refs/heads/master@{#387930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M cc/output/filter_operation.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Stephen White
Ali: PTAL. Thanks!
4 years, 8 months ago (2016-04-18 14:45:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900633002/1
4 years, 8 months ago (2016-04-18 14:45:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 15:46:18 UTC) #7
ajuma
lgtm
4 years, 8 months ago (2016-04-18 16:41:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900633002/1
4 years, 8 months ago (2016-04-18 16:42:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 17:20:04 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:21:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86649e2861205f8ce4d7099cb83b1cd16648dfa8
Cr-Commit-Position: refs/heads/master@{#387930}

Powered by Google App Engine
This is Rietveld 408576698