Include the scheme in the key for QUIC the session map.

net/quic/quic_stream_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_STREAM_FACTORY_H_
 #define NET_QUIC_QUIC_STREAM_FACTORY_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 94 matching lines @@
   // already exists, this method will return OK.  If no matching session exists,
   // this will return ERR_IO_PENDING and will invoke OnRequestComplete
   // asynchronously.
   int Create(const HostPortProxyPair& host_port_proxy_pair,
              bool is_https,
              base::StringPiece method,
              CertVerifier* cert_verifier,
              const BoundNetLog& net_log,
              QuicStreamRequest* request);
 
-  // Returns a newly created QuicHttpStream owned by the caller, if a
-  // matching session already exists.  Returns NULL otherwise.
-  scoped_ptr<QuicHttpStream> CreateIfSessionExists(
-      const HostPortProxyPair& host_port_proxy_pair,
-      const BoundNetLog& net_log);
-
   // Called by a session when it becomes idle.
   void OnIdleSession(QuicClientSession* session);
 
   // Called by a session when it is going away and no more streams should be
   // created on it.
   void OnSessionGoingAway(QuicClientSession* session);
 
   // Called by a session after it shuts down.
   void OnSessionClosed(QuicClientSession* session);
 
@@ skipping 32 matching lines @@
     DCHECK(!quic_server_info_factory_);
     quic_server_info_factory_ = quic_server_info_factory;
   }
 
   bool enable_pacing() const { return enable_pacing_; }
 
  private:
   class Job;
   friend class test::QuicStreamFactoryPeer;
 
-  typedef std::map<HostPortProxyPair, QuicClientSession*> SessionMap;
-  typedef std::set<HostPortProxyPair> AliasSet;
+  // The key used to find session by hostname. Includes
+  // the hostname, port, and scheme.
+  struct SessionKey {
+    SessionKey();
+    SessionKey(HostPortProxyPair host_port_proxy_pair,
+               bool is_https);
+    ~SessionKey();
+
+    HostPortProxyPair host_port_proxy_pair;
+    bool is_https;
+
+    // Needed to be an element of std::set.
+    bool operator<(const SessionKey &other) const;
+    bool operator==(const SessionKey &other) const;
+  };
+
+  // The key used to find session by hostname. Includes
+  // the ip address, port, and scheme.
+  struct IpAliasKey {
+    IpAliasKey();
+    IpAliasKey(IPEndPoint ip_endpoint, bool is_https);
+    ~IpAliasKey();
+
+    IPEndPoint ip_endpoint;
+    bool is_https;
+
+    // Needed to be an element of std::set.
+    bool operator<(const IpAliasKey &other) const;
+    bool operator==(const IpAliasKey &other) const;
+  };
+
+  typedef std::map<SessionKey, QuicClientSession*> SessionMap;
+  typedef std::set<SessionKey> AliasSet;
   typedef std::map<QuicClientSession*, AliasSet> SessionAliasMap;
   typedef std::set<QuicClientSession*> SessionSet;
-  typedef std::map<IPEndPoint, SessionSet> IPAliasMap;
-  typedef std::map<HostPortProxyPair, QuicCryptoClientConfig*> CryptoConfigMap;
-  typedef std::map<HostPortPair, HostPortProxyPair> CanonicalHostMap;
-  typedef std::map<HostPortProxyPair, Job*> JobMap;
+  typedef std::map<IpAliasKey, SessionSet> IPAliasMap;
+  typedef std::map<SessionKey, QuicCryptoClientConfig*> CryptoConfigMap;
+  typedef std::map<SessionKey, SessionKey> CanonicalHostMap;
+  typedef std::map<SessionKey, Job*> JobMap;
   typedef std::map<QuicStreamRequest*, Job*> RequestMap;
   typedef std::set<QuicStreamRequest*> RequestSet;
   typedef std::map<Job*, RequestSet> JobRequestsMap;
 
-  bool OnResolution(const HostPortProxyPair& host_port_proxy_pair,
+  // Returns a newly created QuicHttpStream owned by the caller, if a
+  // matching session already exists.  Returns NULL otherwise.
+  scoped_ptr<QuicHttpStream> CreateIfSessionExists(const SessionKey& key,
+                                                   const BoundNetLog& net_log);
+
+  bool OnResolution(const SessionKey& session_key,
                     const AddressList& address_list);
   void OnJobComplete(Job* job, int rv);
-  bool HasActiveSession(const HostPortProxyPair& host_port_proxy_pair);
-  bool HasActiveJob(const HostPortProxyPair& host_port_proxy_pair);
+  bool HasActiveSession(const SessionKey& session_key) const;
+  bool HasActiveJob(const SessionKey& session_key) const;
   int CreateSession(const HostPortProxyPair& host_port_proxy_pair,
                     bool is_https,
                     CertVerifier* cert_verifier,
                     const AddressList& address_list,
                     const BoundNetLog& net_log,
                     QuicClientSession** session);
-  void ActivateSession(const HostPortProxyPair& host_port_proxy_pair,
+  void ActivateSession(const SessionKey& key,
                        QuicClientSession* session);
 
   QuicCryptoClientConfig* GetOrCreateCryptoConfig(
-      const HostPortProxyPair& host_port_proxy_pair);
+      const SessionKey& session_key);
 
-  // If |host_port_proxy_pair| suffix contains ".c.youtube.com" (in future we
-  // could support other suffixes), then populate |crypto_config| with a
-  // canonical server config data from |canonical_hostname_to_origin_map_| for
-  // that suffix.
+  // If the suffix of the hostname in |session_key| is in |canoncial_suffixes_|,
+  // then populate |crypto_config| with a canonical server config data from
+  // |canonical_hostname_to_origin_map_| for that suffix.
   void PopulateFromCanonicalConfig(
-      const HostPortProxyPair& host_port_proxy_pair,
+      const SessionKey& session_key,
       QuicCryptoClientConfig* crypto_config);
 
   bool require_confirmation_;
   HostResolver* host_resolver_;
   ClientSocketFactory* client_socket_factory_;
   base::WeakPtr<HttpServerProperties> http_server_properties_;
   QuicServerInfoFactory* quic_server_info_factory_;
   QuicCryptoClientStreamFactory* quic_crypto_client_stream_factory_;
   QuicRandom* random_generator_;
   scoped_ptr<QuicClock> clock_;
@@ skipping 15 matching lines @@
   // Origins which have gone away recently.
   AliasSet gone_away_aliases_;
 
   // Contains owning pointers to QuicCryptoClientConfig. QuicCryptoClientConfig
   // contains configuration and cached state about servers.
   // TODO(rtenneti): Persist all_crypto_configs_ to disk and decide when to
   // clear the data in the map.
   CryptoConfigMap all_crypto_configs_;
 
   // Contains a map of servers which could share the same server config. Map
-  // from a Canonical host/port (host is some postfix of host names) to an
-  // actual origin, which has a plausible set of initial certificates (or at
+  // from a Canonical host/port/scheme (host is some postfix of host names) to
+  // an actual origin, which has a plausible set of initial certificates (or at
   // least server public key).
   CanonicalHostMap canonical_hostname_to_origin_map_;
 
   // Contains list of suffixes (for exmaple ".c.youtube.com",
   // ".googlevideo.com") of canoncial hostnames.
   std::vector<std::string> canoncial_suffixes_;
 
   QuicConfig config_;
 
   JobMap active_jobs_;
@@ skipping 19 matching lines @@
   uint64 port_seed_;
 
   base::WeakPtrFactory<QuicStreamFactory> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_STREAM_FACTORY_H_