chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc - Issue 190063006: Infobar Componentization Proof of Concept

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

Issue 190063006: Infobar Componentization Proof of Concept (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor fixes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/infobars/infobars_browsertest.cc ('K') | « chrome/browser/ui/startup/session_crashed_infobar_delegate.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

diff --git a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

index 316dad322e014b114329a62c38c335c829fcbf95..3024b347ca99bad3ec74daad54d862cc958f2187 100644

--- a/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

+++ b/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

@@ -8,6 +8,7 @@

#include "base/prefs/testing_pref_service.h"

#include "base/run_loop.h"

#include "chrome/browser/infobars/infobar.h"

+#include "chrome/browser/infobars/infobar_manager.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/prefs/browser_prefs.h"

#include "chrome/browser/sessions/session_service_factory.h"

@@ -83,9 +84,11 @@ TEST_F(SessionCrashedInfoBarDelegateUnitTest, DetachingTabWithCrashedInfoBar) {

content::WebContents* web_contents = tab_strip->GetWebContentsAt(0);

InfoBarService* infobar_service =

InfoBarService::FromWebContents(web_contents);

- EXPECT_EQ(1U, infobar_service->infobar_count());

- ConfirmInfoBarDelegate* infobar =

- infobar_service->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();

+ EXPECT_EQ(1U, infobar_service->infobar_manager().infobar_count());

+ ConfirmInfoBarDelegate* infobar = infobar_service->infobar_manager()

+ .infobar_at(0)

+ ->delegate()

+ ->AsConfirmInfoBarDelegate();

ASSERT_TRUE(infobar);

// Open another browser.

@@ -104,7 +107,7 @@ TEST_F(SessionCrashedInfoBarDelegateUnitTest, DetachingTabWithCrashedInfoBar) {

ASSERT_EQ(1, tab_strip->count());

web_contents = tab_strip->GetWebContentsAt(0);

infobar_service = InfoBarService::FromWebContents(web_contents);

- EXPECT_EQ(1U, infobar_service->infobar_count());

+ EXPECT_EQ(1U, infobar_service->infobar_manager().infobar_count());

// This used to crash.

infobar->Accept();