chrome/browser/password_manager/save_password_infobar_delegate.cc - Issue 190063006: Infobar Componentization Proof of Concept

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 190063006: Infobar Componentization Proof of Concept (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor fixes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/save_password_infobar_delegate.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc

index 3bf069415ac7ea66de4e6511e3aa2f09684eae90..23b34de91ce5a51aa97a8b832250dac5941a7e39 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc

@@ -108,10 +108,8 @@ scoped_ptr<InfoBar> SavePasswordInfoBarDelegate::CreateInfoBar(

#endif

bool SavePasswordInfoBarDelegate::ShouldExpire(

- const content::LoadCommittedDetails& details) const {

- bool is_not_redirect = !(details.entry->GetTransitionType() &

- content::PAGE_TRANSITION_IS_REDIRECT_MASK);

- return is_not_redirect && InfoBarDelegate::ShouldExpire(details);

+ const NavigationDetails& details) const {

+ return !details.is_redirect && InfoBarDelegate::ShouldExpire(details);

}

int SavePasswordInfoBarDelegate::GetIconID() const {