Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: chrome/test/gpu/webgl_infobar_browsertest.cc

Issue 190063006: Infobar Componentization Proof of Concept (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor fixes Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/infobars/confirm_infobar_delegate.h" 9 #include "chrome/browser/infobars/confirm_infobar_delegate.h"
10 #include "chrome/browser/infobars/infobar.h" 10 #include "chrome/browser/infobars/infobar.h"
11 #include "chrome/browser/infobars/infobar_manager.h"
11 #include "chrome/browser/infobars/infobar_service.h" 12 #include "chrome/browser/infobars/infobar_service.h"
12 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/browser_commands.h" 14 #include "chrome/browser/ui/browser_commands.h"
14 #include "chrome/browser/ui/browser_navigator.h" 15 #include "chrome/browser/ui/browser_navigator.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 16 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "chrome/common/chrome_paths.h" 17 #include "chrome/common/chrome_paths.h"
17 #include "chrome/common/chrome_switches.h" 18 #include "chrome/common/chrome_switches.h"
18 #include "chrome/common/url_constants.h" 19 #include "chrome/common/url_constants.h"
19 #include "chrome/test/base/in_process_browser_test.h" 20 #include "chrome/test/base/in_process_browser_test.h"
20 #include "chrome/test/base/test_launcher_utils.h" 21 #include "chrome/test/base/test_launcher_utils.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 gpu_test_dir_.AppendASCII("webgl.html"), "query=kill")); 83 gpu_test_dir_.AppendASCII("webgl.html"), "query=kill"));
83 observer.Wait(); 84 observer.Wait();
84 85
85 content::WindowedNotificationObserver infobar_added( 86 content::WindowedNotificationObserver infobar_added(
86 chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED, 87 chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
87 content::NotificationService::AllSources()); 88 content::NotificationService::AllSources());
88 SimulateGPUCrash(browser()); 89 SimulateGPUCrash(browser());
89 infobar_added.Wait(); 90 infobar_added.Wait();
90 EXPECT_EQ(1u, 91 EXPECT_EQ(1u,
91 InfoBarService::FromWebContents( 92 InfoBarService::FromWebContents(
92 browser()->tab_strip_model()->GetActiveWebContents())-> 93 browser()->tab_strip_model()->GetActiveWebContents())
93 infobar_count()); 94 ->infobar_manager()
95 .infobar_count());
94 } 96 }
95 97
96 // This test is flaky. http://crbug.com/324555 98 // This test is flaky. http://crbug.com/324555
97 IN_PROC_BROWSER_TEST_F(WebGLInfoBarTest, DISABLED_ContextLossInfoBarReload) { 99 IN_PROC_BROWSER_TEST_F(WebGLInfoBarTest, DISABLED_ContextLossInfoBarReload) {
98 #if defined(OS_WIN) && defined(USE_ASH) 100 #if defined(OS_WIN) && defined(USE_ASH)
99 // Disable this test in Metro+Ash for now (http://crbug.com/262796). 101 // Disable this test in Metro+Ash for now (http://crbug.com/262796).
100 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests)) 102 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
101 return; 103 return;
102 #endif 104 #endif
103 105
(...skipping 19 matching lines...) Expand all
123 125
124 message_queue.ClearQueue(); 126 message_queue.ClearQueue();
125 127
126 content::WindowedNotificationObserver infobar_added( 128 content::WindowedNotificationObserver infobar_added(
127 chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED, 129 chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
128 content::NotificationService::AllSources()); 130 content::NotificationService::AllSources());
129 SimulateGPUCrash(browser()); 131 SimulateGPUCrash(browser());
130 infobar_added.Wait(); 132 infobar_added.Wait();
131 InfoBarService* infobar_service = InfoBarService::FromWebContents( 133 InfoBarService* infobar_service = InfoBarService::FromWebContents(
132 browser()->tab_strip_model()->GetActiveWebContents()); 134 browser()->tab_strip_model()->GetActiveWebContents());
133 ASSERT_EQ(1u, infobar_service->infobar_count()); 135 ASSERT_EQ(1u, infobar_service->infobar_manager().infobar_count());
134 InfoBarDelegate* delegate = infobar_service->infobar_at(0)->delegate(); 136 InfoBarDelegate* delegate =
137 infobar_service->infobar_manager().infobar_at(0)->delegate();
135 ASSERT_TRUE(delegate->AsThreeDAPIInfoBarDelegate()); 138 ASSERT_TRUE(delegate->AsThreeDAPIInfoBarDelegate());
136 delegate->AsConfirmInfoBarDelegate()->Cancel(); 139 delegate->AsConfirmInfoBarDelegate()->Cancel();
137 140
138 // The page should reload and another message sent to the 141 // The page should reload and another message sent to the
139 // DomAutomationController. 142 // DomAutomationController.
140 m.clear(); 143 m.clear();
141 ASSERT_TRUE(message_queue.WaitForMessage(&m)); 144 ASSERT_TRUE(message_queue.WaitForMessage(&m));
142 EXPECT_EQ("\"LOADED\"", m); 145 EXPECT_EQ("\"LOADED\"", m);
143 } 146 }
144 147
145 // There isn't any point in adding a test which calls Accept() on the 148 // There isn't any point in adding a test which calls Accept() on the
146 // ThreeDAPIInfoBarDelegate; doing so doesn't remove the infobar, and 149 // ThreeDAPIInfoBarDelegate; doing so doesn't remove the infobar, and
147 // there's no concrete event that could be observed in response. 150 // there's no concrete event that could be observed in response.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698