[compiler] Let CompileForLiveEdit use common pipeline.

[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org

Committed: https://crrev.com/1041340220bd81cf671c65ad24408f0265f0e2e0
Cr-Commit-Position: refs/heads/master@{#35590}

[Michael Starzinger, 2016-04-18 14:49:25]

Description was changed from

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=
==========

to

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org
==========

[Michael Starzinger, 2016-04-18 14:49:25]

mstarzinger@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-04-18 14:58:21]

lgtm

https://codereview.chromium.org/1900613002/diff/1/src/compiler.cc
File src/compiler.cc (left):

https://codereview.chromium.org/1900613002/diff/1/src/compiler.cc#oldcode1199
src/compiler.cc:1199: tracker.RecordRootFunctionInfo(info.code());
Can we remove this method now?

[Michael Starzinger, 2016-04-18 16:03:07]

Thanks! Addressed comments. Will land tomorrow probably.

https://codereview.chromium.org/1900613002/diff/1/src/compiler.cc
File src/compiler.cc (left):

https://codereview.chromium.org/1900613002/diff/1/src/compiler.cc#oldcode1199
src/compiler.cc:1199: tracker.RecordRootFunctionInfo(info.code());
On 2016/04/18 14:58:21, Yang wrote:
> Can we remove this method now?

Done. Yes, you are right, not called anymore. :)

[Michael Starzinger, 2016-04-18 16:14:10]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-18 16:14:10]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1900613002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-04-18 16:14:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900613002/20001

[commit-bot: I haz the power, 2016-04-18 16:16:22]

Description was changed from

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org
==========

to

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-04-18 16:16:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-18 16:17:30]

Description was changed from

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org
==========

to

==========
[compiler] Let CompileForLiveEdit use common pipeline.

This makes sure that the Compiler::CompileForLiveEdit API function uses
the common pipeline for top-level code. It ensures that a proper shared
function info object is allocated before compilation is triggered.

R=yangguo@chromium.org

Committed: https://crrev.com/1041340220bd81cf671c65ad24408f0265f0e2e0
Cr-Commit-Position: refs/heads/master@{#35590}
==========

[commit-bot: I haz the power, 2016-04-18 16:17:31]

Patchset 2 (id:??) landed as
https://crrev.com/1041340220bd81cf671c65ad24408f0265f0e2e0
Cr-Commit-Position: refs/heads/master@{#35590}