Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/platform/Prerender.h

Issue 1900583002: Abandon prerenders upon render thread shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: abandon prerenders upon PrerenderDispatcher::OnRenderProcessShutdown() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/prerender/prerender_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/Prerender.h
diff --git a/third_party/WebKit/Source/platform/Prerender.h b/third_party/WebKit/Source/platform/Prerender.h
index e942e0e5d39261116e712a800fa907abae326f73..aff87ae14831b98176a334ccc2303dd52a2664b7 100644
--- a/third_party/WebKit/Source/platform/Prerender.h
+++ b/third_party/WebKit/Source/platform/Prerender.h
@@ -83,7 +83,11 @@ public:
private:
Prerender(PrerenderClient*, const KURL&, unsigned relTypes, const Referrer&);
- Member<PrerenderClient> m_client;
+ // The embedder's prerendering support holds on to pending Prerender objects;
+ // those references should not keep the PrerenderClient alive -- if the client
+ // becomes otherwise unreachable it should be GCed (at which point it will
+ // abandon this Prerender object.)
+ WeakMember<PrerenderClient> m_client;
const KURL m_url;
const unsigned m_relTypes;
« no previous file with comments | « chrome/renderer/prerender/prerender_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698