Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1900563002: [turbofan] Fix undefined behavior in Int64Lowering. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix undefined behavior in Int64Lowering. This fixes undefined behavior introduced by extracting the const call descriptor of a call node as non-const. Such an implicit cast between constness is not safe and should be avoided. R=ahaas@chromium.org TEST=unittests/Int64LoweringTest.CallI64Parameter BUG=v8:4924 LOG=n Committed: https://crrev.com/dee91da817f3cf0ab373463cfa9c390de529c03d Cr-Commit-Position: refs/heads/master@{#35569}

Patch Set 1 #

Patch Set 2 : Workaround with const-cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler/int64-lowering.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
LGTM. Can we pretty please have CallDescriptorOf?
4 years, 8 months ago (2016-04-18 09:20:13 UTC) #2
Michael Starzinger
On 2016/04/18 09:20:13, Benedikt Meurer wrote: > LGTM. Can we pretty please have CallDescriptorOf? Yes, ...
4 years, 8 months ago (2016-04-18 09:38:55 UTC) #3
Michael Starzinger
4 years, 8 months ago (2016-04-18 09:39:00 UTC) #4
ahaas
lgtm
4 years, 8 months ago (2016-04-18 09:56:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900563002/20001
4 years, 8 months ago (2016-04-18 09:57:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 09:59:37 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 10:01:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dee91da817f3cf0ab373463cfa9c390de529c03d
Cr-Commit-Position: refs/heads/master@{#35569}

Powered by Google App Engine
This is Rietveld 408576698