src/IceTargetLoweringMIPS32.cpp - Issue 1900543002: Subzero: Allow per-method controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 1900543002: Subzero: Allow per-method controls. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More cleanup Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index 238b7bb9d8eb52dddae9b0685600022b5c0d1935..1bc15e3aebc40ded67ed8b8fd2ef7b7661bd74dc 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -1211,10 +1211,9 @@ void TargetDataMIPS32::lowerGlobals(const VariableDeclarationList &Vars,

} break;

case FT_Asm:

case FT_Iasm: {

- const std::string TranslateOnly = getFlags().getTranslateOnly();

OstreamLocker L(Ctx);

for (const VariableDeclaration *Var : Vars) {

- if (GlobalContext::matchSymbolName(Var->getName(), TranslateOnly)) {

+ if (getFlags().matchTranslateOnly(Var->getName(), 0)) {

emitGlobal(*Var, SectionSuffix);

}