Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1900523003: Revert "2D canvas: pass unmodified primitive bounds to saveLayer()." (Closed)

Created:
4 years, 8 months ago by Stephen White
Modified:
4 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, haraken, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "2D canvas: pass unmodified primitive bounds to saveLayer()." This is a manual revert, since Skia has changed in the meantime (e.g., no longer requires filtered bounds to be passed to saveLayer()). R=junov@chromium.org BUG=602933 Committed: https://crrev.com/d21fd4984450f9b8cca710bf76a05beec62e243a Cr-Commit-Position: refs/heads/master@{#388272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Stephen White
Justin: PTAL. Thanks!
4 years, 8 months ago (2016-04-18 21:47:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900523003/1
4 years, 8 months ago (2016-04-18 21:48:12 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/55790)
4 years, 8 months ago (2016-04-18 23:49:27 UTC) #5
Justin Novosad
lgtm
4 years, 8 months ago (2016-04-19 18:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900523003/1
4 years, 8 months ago (2016-04-19 18:36:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:25:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d21fd4984450f9b8cca710bf76a05beec62e243a
Cr-Commit-Position: refs/heads/master@{#388272}

Powered by Google App Engine
This is Rietveld 408576698