Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1900503002: More steps toward making server strong mode clean (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 4 chunks +12 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-18 04:14:37 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-18 04:33:13 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-18 14:52:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ab253b9776f2f3fbb2b717a524d294e45a274bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698