Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: ash/wm/window_positioner.h

Issue 1900443002: Removes aura dependencies from WindowPositioner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GetBounds Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_positioner.h
diff --git a/ash/wm/window_positioner.h b/ash/wm/window_positioner.h
index ad66a7b4fcdacc1b828ce2390db8840fa4335fc1..d96b0ddb8fccfd3c4ece36a433bb7967dbd05e1b 100644
--- a/ash/wm/window_positioner.h
+++ b/ash/wm/window_positioner.h
@@ -8,12 +8,6 @@
#include "ash/ash_export.h"
#include "base/macros.h"
#include "ui/base/ui_base_types.h"
-#include "ui/gfx/geometry/rect.h"
-
-namespace aura {
-class Window;
-class RootWindow;
-}
namespace gfx {
class Display;
@@ -22,6 +16,10 @@ class Screen;
}
namespace ash {
+namespace wm {
+class WmGlobals;
+class WmWindow;
+}
namespace test {
class WindowPositionerTest;
@@ -51,7 +49,7 @@ class ASH_EXPORT WindowPositioner {
// bounds.
static void GetBoundsAndShowStateForNewWindow(
const gfx::Screen* screen,
- const aura::Window* new_window,
+ const wm::WmWindow* new_window,
bool is_saved_bounds,
ui::WindowShowState show_state_in,
gfx::Rect* bounds_in_out,
@@ -64,7 +62,7 @@ class ASH_EXPORT WindowPositioner {
// automated desktop location management can be performed and
// rearrange accordingly.
static void RearrangeVisibleWindowOnHideOrRemove(
- const aura::Window* removed_window);
+ const wm::WmWindow* removed_window);
// Turn the automatic positioning logic temporarily off. Returns the previous
// state.
@@ -73,9 +71,9 @@ class ASH_EXPORT WindowPositioner {
// Check if after insertion or showing of the given |added_window|
// an automated desktop location management can be performed and
// rearrange accordingly.
- static void RearrangeVisibleWindowOnShow(aura::Window* added_window);
+ static void RearrangeVisibleWindowOnShow(wm::WmWindow* added_window);
- WindowPositioner();
+ explicit WindowPositioner(wm::WmGlobals* globals);
~WindowPositioner();
// Find a suitable screen position for a popup window and return it. The
@@ -110,6 +108,8 @@ class ASH_EXPORT WindowPositioner {
// Constant exposed for unittest.
static const int kMinimumWindowOffset;
+ wm::WmGlobals* globals_;
+
// The offset in X and Y for the next popup which opens.
int pop_position_offset_increment_x;
int pop_position_offset_increment_y;

Powered by Google App Engine
This is Rietveld 408576698