Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: ash/wm/window_positioner.h

Issue 1900443002: Removes aura dependencies from WindowPositioner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GetBounds Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_WM_WINDOW_POSITIONER_H_ 5 #ifndef ASH_WM_WINDOW_POSITIONER_H_
6 #define ASH_WM_WINDOW_POSITIONER_H_ 6 #define ASH_WM_WINDOW_POSITIONER_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "ui/base/ui_base_types.h" 10 #include "ui/base/ui_base_types.h"
11 #include "ui/gfx/geometry/rect.h"
12
13 namespace aura {
14 class Window;
15 class RootWindow;
16 }
17 11
18 namespace gfx { 12 namespace gfx {
19 class Display; 13 class Display;
20 class Rect; 14 class Rect;
21 class Screen; 15 class Screen;
22 } 16 }
23 17
24 namespace ash { 18 namespace ash {
19 namespace wm {
20 class WmGlobals;
21 class WmWindow;
22 }
25 23
26 namespace test { 24 namespace test {
27 class WindowPositionerTest; 25 class WindowPositionerTest;
28 } 26 }
29 27
30 // WindowPositioner is used by the browser to move new popups automatically to 28 // WindowPositioner is used by the browser to move new popups automatically to
31 // a usable position on the closest work area (of the active window). 29 // a usable position on the closest work area (of the active window).
32 class ASH_EXPORT WindowPositioner { 30 class ASH_EXPORT WindowPositioner {
33 public: 31 public:
34 // When the screen resolution width is smaller then this size, The algorithm 32 // When the screen resolution width is smaller then this size, The algorithm
35 // will default to maximized. 33 // will default to maximized.
36 static int GetForceMaximizedWidthLimit(); 34 static int GetForceMaximizedWidthLimit();
37 35
38 // The number of pixels which are kept free top, left and right when a window 36 // The number of pixels which are kept free top, left and right when a window
39 // gets positioned to its default location. 37 // gets positioned to its default location.
40 static const int kDesktopBorderSize; 38 static const int kDesktopBorderSize;
41 39
42 // Maximum width of a window even if there is more room on the desktop. 40 // Maximum width of a window even if there is more room on the desktop.
43 static const int kMaximumWindowWidth; 41 static const int kMaximumWindowWidth;
44 42
45 // Computes and returns the bounds and show state for new window 43 // Computes and returns the bounds and show state for new window
46 // based on the parameter passed AND existing windows. |window| is 44 // based on the parameter passed AND existing windows. |window| is
47 // the one this function will generate a bounds for and used to 45 // the one this function will generate a bounds for and used to
48 // exclude the self window in making decision how to position the 46 // exclude the self window in making decision how to position the
49 // window. |window| can be (and in most case) NULL. 47 // window. |window| can be (and in most case) NULL.
50 // |is_saved_bounds| indicates the |bounds_in_out| is the saved 48 // |is_saved_bounds| indicates the |bounds_in_out| is the saved
51 // bounds. 49 // bounds.
52 static void GetBoundsAndShowStateForNewWindow( 50 static void GetBoundsAndShowStateForNewWindow(
53 const gfx::Screen* screen, 51 const gfx::Screen* screen,
54 const aura::Window* new_window, 52 const wm::WmWindow* new_window,
55 bool is_saved_bounds, 53 bool is_saved_bounds,
56 ui::WindowShowState show_state_in, 54 ui::WindowShowState show_state_in,
57 gfx::Rect* bounds_in_out, 55 gfx::Rect* bounds_in_out,
58 ui::WindowShowState* show_state_out); 56 ui::WindowShowState* show_state_out);
59 57
60 // Returns the default bounds for a window to be created in the |display|. 58 // Returns the default bounds for a window to be created in the |display|.
61 static gfx::Rect GetDefaultWindowBounds(const gfx::Display& display); 59 static gfx::Rect GetDefaultWindowBounds(const gfx::Display& display);
62 60
63 // Check if after removal or hide of the given |removed_window| an 61 // Check if after removal or hide of the given |removed_window| an
64 // automated desktop location management can be performed and 62 // automated desktop location management can be performed and
65 // rearrange accordingly. 63 // rearrange accordingly.
66 static void RearrangeVisibleWindowOnHideOrRemove( 64 static void RearrangeVisibleWindowOnHideOrRemove(
67 const aura::Window* removed_window); 65 const wm::WmWindow* removed_window);
68 66
69 // Turn the automatic positioning logic temporarily off. Returns the previous 67 // Turn the automatic positioning logic temporarily off. Returns the previous
70 // state. 68 // state.
71 static bool DisableAutoPositioning(bool ignore); 69 static bool DisableAutoPositioning(bool ignore);
72 70
73 // Check if after insertion or showing of the given |added_window| 71 // Check if after insertion or showing of the given |added_window|
74 // an automated desktop location management can be performed and 72 // an automated desktop location management can be performed and
75 // rearrange accordingly. 73 // rearrange accordingly.
76 static void RearrangeVisibleWindowOnShow(aura::Window* added_window); 74 static void RearrangeVisibleWindowOnShow(wm::WmWindow* added_window);
77 75
78 WindowPositioner(); 76 explicit WindowPositioner(wm::WmGlobals* globals);
79 ~WindowPositioner(); 77 ~WindowPositioner();
80 78
81 // Find a suitable screen position for a popup window and return it. The 79 // Find a suitable screen position for a popup window and return it. The
82 // passed input position is only used to retrieve the width and height. 80 // passed input position is only used to retrieve the width and height.
83 // The position is determined on the left / right / top / bottom first. If 81 // The position is determined on the left / right / top / bottom first. If
84 // no smart space is found, the position will follow the standard what other 82 // no smart space is found, the position will follow the standard what other
85 // operating systems do (default cascading style). 83 // operating systems do (default cascading style).
86 gfx::Rect GetPopupPosition(const gfx::Rect& old_pos); 84 gfx::Rect GetPopupPosition(const gfx::Rect& old_pos);
87 85
88 // Accessor to set a flag indicating whether the first window in ASH should 86 // Accessor to set a flag indicating whether the first window in ASH should
(...skipping 14 matching lines...) Expand all
103 const gfx::Rect& work_area); 101 const gfx::Rect& work_area);
104 102
105 // Align the location to the grid / snap to the right / bottom corner. 103 // Align the location to the grid / snap to the right / bottom corner.
106 gfx::Rect AlignPopupPosition(const gfx::Rect &pos, 104 gfx::Rect AlignPopupPosition(const gfx::Rect &pos,
107 const gfx::Rect &work_area, 105 const gfx::Rect &work_area,
108 int grid); 106 int grid);
109 107
110 // Constant exposed for unittest. 108 // Constant exposed for unittest.
111 static const int kMinimumWindowOffset; 109 static const int kMinimumWindowOffset;
112 110
111 wm::WmGlobals* globals_;
112
113 // The offset in X and Y for the next popup which opens. 113 // The offset in X and Y for the next popup which opens.
114 int pop_position_offset_increment_x; 114 int pop_position_offset_increment_x;
115 int pop_position_offset_increment_y; 115 int pop_position_offset_increment_y;
116 116
117 // The position on the screen for the first popup which gets shown if no 117 // The position on the screen for the first popup which gets shown if no
118 // empty space can be found. 118 // empty space can be found.
119 int popup_position_offset_from_screen_corner_x; 119 int popup_position_offset_from_screen_corner_x;
120 int popup_position_offset_from_screen_corner_y; 120 int popup_position_offset_from_screen_corner_y;
121 121
122 // The last used position. 122 // The last used position.
123 int last_popup_position_x_; 123 int last_popup_position_x_;
124 int last_popup_position_y_; 124 int last_popup_position_y_;
125 125
126 DISALLOW_COPY_AND_ASSIGN(WindowPositioner); 126 DISALLOW_COPY_AND_ASSIGN(WindowPositioner);
127 }; 127 };
128 128
129 } // namespace ash 129 } // namespace ash
130 130
131 #endif // ASH_WM_WINDOW_POSITIONER_H_ 131 #endif // ASH_WM_WINDOW_POSITIONER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698