Removes aura dependencies from WindowPositioner

ash/wm/aura/wm_window_aura.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/aura/wm_window_aura.h"
 
 #include "ash/screen_util.h"
+#include "ash/wm/aura/wm_globals_aura.h"
 #include "ash/wm/aura/wm_root_window_controller_aura.h"
 #include "ash/wm/common/wm_window_observer.h"
 #include "ash/wm/common/wm_window_property.h"
 #include "ash/wm/window_animations.h"
 #include "ash/wm/window_properties.h"
 #include "ash/wm/window_state.h"
 #include "ash/wm/window_state_aura.h"
 #include "ash/wm/window_util.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/layout_manager.h"
@@ skipping 68 matching lines @@
 
 const WmWindow* WmWindowAura::GetRootWindow() const {
   return Get(window_->GetRootWindow());
 }
 
 WmRootWindowController* WmWindowAura::GetRootWindowController() {
   aura::Window* root = window_->GetRootWindow();
   return root ? WmRootWindowControllerAura::Get(root) : nullptr;
 }
 
+WmGlobals* WmWindowAura::GetGlobals() const {
+  return WmGlobalsAura::Get();
+}
+
 int WmWindowAura::GetShellWindowId() {
   return window_->id();
 }
 
 ui::wm::WindowType WmWindowAura::GetType() const {
   return window_->type();
 }
 
 ui::Layer* WmWindowAura::GetLayer() {
   return window_->layer();
@@ skipping 64 matching lines @@
       return window_->GetProperty(kSnapChildrenToPixelBoundary);
 
     case WmWindowProperty::ALWAYS_ON_TOP:
       return window_->GetProperty(aura::client::kAlwaysOnTopKey);
   }
 
   NOTREACHED();
   return false;
 }
 
-WindowState* WmWindowAura::GetWindowState() {
+const WindowState* WmWindowAura::GetWindowState() const {
   return ash::wm::GetWindowState(window_);
 }
 
 WmWindow* WmWindowAura::GetToplevelWindow() {
   return Get(window_->GetToplevelWindow());
 }
 
 WmWindow* WmWindowAura::GetParent() {
   return Get(window_->parent());
 }
 
 WmWindow* WmWindowAura::GetTransientParent() {
   return Get(::wm::GetTransientParent(window_));
 }
 
+std::vector<WmWindow*> WmWindowAura::GetTransientChildren() {
+  const std::vector<aura::Window*> aura_windows(
+      ::wm::GetTransientChildren(window_));
+  std::vector<WmWindow*> wm_windows(aura_windows.size());
+  for (size_t i = 0; i < aura_windows.size(); ++i)
+    wm_windows[i] = Get(aura_windows[i]);

[oshima, 2016/04/18 18:09:17]

Looks like we're converting aura window -> wm window in several places. It may
be useful to have a utility function to convert from  vector<aura::Window> to
vector<WmWindow>

+  return wm_windows;
+}
+
 void WmWindowAura::SetBounds(const gfx::Rect& bounds) {
   window_->SetBounds(bounds);
 }
 
+void WmWindowAura::SetBoundsWithTransitionDelay(const gfx::Rect& bounds,
+                                                base::TimeDelta delta) {
+  if (::wm::WindowAnimationsDisabled(window_)) {
+    window_->SetBounds(bounds);
+    return;
+  }
+
+  ui::ScopedLayerAnimationSettings settings(window_->layer()->GetAnimator());
+  settings.SetTransitionDuration(delta);
+  window_->SetBounds(bounds);
+}
+
 void WmWindowAura::SetBoundsDirect(const gfx::Rect& bounds) {
   BoundsSetter().SetBounds(window_, bounds);
   SnapWindowToPixelBoundary(window_);
 }
 
 void WmWindowAura::SetBoundsDirectAnimated(const gfx::Rect& bounds) {
   const int kBoundsChangeSlideDurationMs = 120;
 
   ui::Layer* layer = window_->layer();
   ui::ScopedLayerAnimationSettings slide_settings(layer->GetAnimator());
@@ skipping 231 matching lines @@
   FOR_EACH_OBSERVER(WmWindowObserver, observers_,
                     OnWindowBoundsChanged(this, old_bounds, new_bounds));
 }
 
 void WmWindowAura::OnWindowDestroying(aura::Window* window) {
   FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this));
 }
 
 }  // namespace wm
 }  // namespace ash