Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp

Issue 1900423004: [compositorworker] Register compositor proxies with proxy client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor update Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp b/third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp
index 785f096b53c210fa47430bbbf0c614d36fad27c0..1219cccdf69065dcfee9b2a21e1f1baa13e2718e 100644
--- a/third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp
+++ b/third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp
@@ -23,6 +23,7 @@ DEFINE_TRACE(CompositorProxyClientImpl)
CompositorProxyClient::trace(visitor);
visitor->trace(m_mutator);
visitor->trace(m_globalScope);
+ visitor->trace(m_proxyMap);
}
void CompositorProxyClientImpl::setGlobalScope(WorkerGlobalScope* scope)
@@ -64,4 +65,38 @@ bool CompositorProxyClientImpl::executeAnimationFrameCallbacks(double monotonicT
return shouldReinvoke;
}
+void CompositorProxyClientImpl::registerCompositorProxy(CompositorProxy* proxy)
+{
+ uint64_t elementId = proxy->elementId();
+
+ TRACE_EVENT2("compositor-worker,compositor-proxy",
haraken 2016/06/08 00:10:36 registerCompositorProxy should be cheap, so it won
majidvp 2016/06/09 20:34:21 Removed. We were using them as a way to trace the
+ "CompositorProxyClientImpl::registerCompositorProxy",
+ "elementId", static_cast<int>(elementId),
+ "proxy", proxy);
+
+ ProxyMap::AddResult entry = m_proxyMap.add(elementId, new ProxyVector);
+ ProxyVector* proxies = entry.storedValue->value;
+ if (!proxies->contains(proxy))
+ proxies->append(proxy);
+}
+
+void CompositorProxyClientImpl::unregisterCompositorProxy(CompositorProxy* proxy)
+{
+ uint64_t elementId = proxy->elementId();
+ if (ProxyVector* proxies = m_proxyMap.get(elementId)) {
+ TRACE_EVENT2("compositor-worker,compositor-proxy",
haraken 2016/06/08 00:10:36 Ditto.
+ "CompositorProxyClientImpl::unregisterCompositorProxy",
+ "elementId", static_cast<int>(elementId),
+ "proxy", proxy);
+
+ size_t position = proxies->find(proxy);
+ if (position == kNotFound)
+ return;
+
+ proxies->remove(position);
+ if (proxies->isEmpty())
+ m_proxyMap.remove(elementId);
+ }
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698