third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js - Issue 1900423004: [compositorworker] Register compositor proxies with proxy client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js

Issue 1900423004: [compositorworker] Register compositor proxies with proxy client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-postmessage.html ('K') | « third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-postmessage.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | third_party/WebKit/Source/core/dom/CompositorProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js

diff --git a/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js b/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js

index 7e5b6099fe5238f750cdafa91f8a6a0b95f4cabd..95ee9e81b7b008750c3f1d216262e037a4d9bda3 100644

--- a/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js

+++ b/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js

@@ -3,5 +3,10 @@ onmessage = function(msg) {

if (typeof proxy == "CompositorProxy")

jbroman 2016/06/09 21:13:47 By the way, what's this condition checking? How ca

majidvp 2016/06/10 15:33:47 Done. + some other minor cleanups.

postMessage({type: "error"});

else

- postMessage({type: 'response', opacity: proxy.supports('opacity'), transform: proxy.supports('transform')});

+ postMessage({

+ type: "response",

+ opacity: proxy.supports("opacity"),

+ transform: proxy.supports("transform"),

+ proxy: proxy

+ });

}