[compositorworker] Register compositor proxies with proxy client

third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/CompositorProxyClientImpl.h"
 
 #include "core/dom/CompositorProxy.h"
 #include "modules/compositorworker/CompositorWorkerGlobalScope.h"
 #include "platform/TraceEvent.h"
 #include "web/CompositorMutatorImpl.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 
 CompositorProxyClientImpl::CompositorProxyClientImpl(CompositorMutatorImpl* mutator)
     : m_mutator(mutator)
     , m_globalScope(nullptr)
 {
 }
 
 DEFINE_TRACE(CompositorProxyClientImpl)
 {
     CompositorProxyClient::trace(visitor);
     visitor->trace(m_mutator);
     visitor->trace(m_globalScope);
+    visitor->trace(m_proxyMap);
 }
 
 void CompositorProxyClientImpl::setGlobalScope(WorkerGlobalScope* scope)
 {
     TRACE_EVENT0("compositor-worker", "CompositorProxyClientImpl::setGlobalScope");
     DCHECK(!m_globalScope);
     DCHECK(scope);
     m_globalScope = static_cast<CompositorWorkerGlobalScope*>(scope);
     m_mutator->registerProxyClient(this);
 }
@@ skipping 21 matching lines @@
 
 bool CompositorProxyClientImpl::executeAnimationFrameCallbacks(double monotonicTimeNow)
 {
     TRACE_EVENT0("compositor-worker", "CompositorProxyClientImpl::executeAnimationFrameCallbacks");
     // Convert to zero based document time in milliseconds consistent with requestAnimationFrame.
     double highResTimeMs = 1000.0 * (monotonicTimeNow - m_globalScope->timeOrigin());
     const bool shouldReinvoke = m_globalScope->executeAnimationFrameCallbacks(highResTimeMs);
     return shouldReinvoke;
 }
 
+void CompositorProxyClientImpl::registerCompositorProxy(CompositorProxy* proxy)
+{
+    uint64_t elementId = proxy->elementId();
+    ProxyMap::AddResult entry = m_proxyMap.add(elementId, new ProxySet);

[jbroman, 2016/06/10 17:45:42]

This will create a spurious "new ProxySet" every time, which you don't want to
do. Instead, only allocate it if there wasn't one previously. Similarly, the
"contains" check is redundant: it's legal (and faster) to unconditionally add it
(the set itself will not contain duplicate entries, and will only scan the
hashtable once this way).

ProxyMap::AddResult entry = m_proxyMap.add(proxy->elementId(), nullptr);
Member<ProxySet>& proxies = entry.storedValue->value;
if (entry.isNewEntry)
    proxies = new ProxySet;
proxies->add(proxy);

[majidvp, 2016/06/10 19:17:51]

Great! I like this pattern of using isNewEntry. Thanks.

+    ProxySet* proxies = entry.storedValue->value;
+    if (!proxies->contains(proxy))
+        proxies->add(proxy);
+}
+
+void CompositorProxyClientImpl::unregisterCompositorProxy(CompositorProxy* proxy)
+{
+    uint64_t elementId = proxy->elementId();
+    if (ProxySet* proxies = m_proxyMap.get(elementId)) {
+        proxies->remove(proxy);
+        if (proxies->isEmpty())
+            m_proxyMap.remove(elementId);

[jbroman, 2016/06/10 17:45:42]

This case is probably less worrisome, but this is still one more hashtable scan
than necessary. You might consider this pattern instead (slightly more
complicated, but only one line longer):

ProxyMap::iterator it = m_proxyMap.find(proxy->elementId());
if (it == m_proxyMap.end())
    return;

ProxySet* proxies = it->value;
proxies->remove(proxy);
if (proxies->isEmpty())
    m_proxyMap.remove(it);

...but I'm less worried about this than the extra allocation above.

[majidvp, 2016/06/10 19:17:51]

Done.

+    }
+}
+
 } // namespace blink