third_party/WebKit/Source/core/dom/CompositorProxyClient.h - Issue 1900423004: [compositorworker] Register compositor proxies with proxy client

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/CompositorProxyClient.h

Issue 1900423004: [compositorworker] Register compositor proxies with proxy client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix layout test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/dom/CompositorProxy.h ('K') | « third_party/WebKit/Source/core/dom/CompositorProxy.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp » ('j') | third_party/WebKit/Source/web/CompositorProxyClientImpl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CompositorProxyClient_h	5 #ifndef CompositorProxyClient_h

6 #define CompositorProxyClient_h	6 #define CompositorProxyClient_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/workers/WorkerClients.h"	9 #include "core/workers/WorkerClients.h"

10 #include "wtf/Noncopyable.h"	10 #include "wtf/Noncopyable.h"

(...skipping 12 matching lines...) Expand all Loading...
23 WTF_MAKE_NONCOPYABLE(CompositorProxyClient);	23 WTF_MAKE_NONCOPYABLE(CompositorProxyClient);

24	24

25 public:	25 public:

26 CompositorProxyClient() {}	26 CompositorProxyClient() {}

27	27

28 static CompositorProxyClient* from(WorkerClients*);	28 static CompositorProxyClient* from(WorkerClients*);

29 static const char* supplementName();	29 static const char* supplementName();

30	30

31 virtual void setGlobalScope(WorkerGlobalScope*) = 0;	31 virtual void setGlobalScope(WorkerGlobalScope*) = 0;

32 virtual void requestAnimationFrame() = 0;	32 virtual void requestAnimationFrame() = 0;

	33 virtual void registerCompositorProxy(CompositorProxy*) = 0;

	34 virtual void unregisterCompositorProxy(CompositorProxy*) = 0;
	jbroman 2016/06/10 17:45:42 Does this method have any call sites? I see the re Does this method have any call sites? I see the registration call site, but not the deregistration site. majidvp 2016/06/10 19:17:50 It should be used in \|CompositorProxy::disconnet\| Show quoted text On 2016/06/10 17:45:42, jbroman wrote: > Does this method have any call sites? I see the registration call site, but not > the deregistration site. It should be used in \|CompositorProxy::disconnet\| which may be called by script. I was to hasty to remove that call site when switched to using weak map. It is corrected now.
33 };	35 };

34	36

35 CORE_EXPORT void provideCompositorProxyClientTo(WorkerClients, CompositorProxyC lient);	37 CORE_EXPORT void provideCompositorProxyClientTo(WorkerClients, CompositorProxyC lient);

36	38

37 } // namespace blink	39 } // namespace blink

38	40

39 #endif // CompositorProxyClient_h	41 #endif // CompositorProxyClient_h

OLD	NEW