[heap] Merge NewSpacePage into Page

[heap] Merge NewSpacePage into Page

BUG=chromium:581412
LOG=N

Committed: https://crrev.com/4e8736da2da2281979cdb0e97a34fd490644bb3d
Cr-Commit-Position: refs/heads/master@{#35768}

[Michael Lippautz, 2016-04-20 14:40:51]

Patchset #3 (id:40001) has been deleted

[Michael Lippautz, 2016-04-20 15:26:53]

Patchset #8 (id:160001) has been deleted

[Michael Lippautz, 2016-04-20 15:31:11]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 15:31:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900423002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900423002/180001

[commit-bot: I haz the power, 2016-04-20 16:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:25:41]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-04-20 17:06:50]

Patchset #9 (id:200001) has been deleted

[Michael Lippautz, 2016-04-20 17:07:59]

Patchset #4 (id:80001) has been deleted

[Michael Lippautz, 2016-04-20 17:16:31]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-04-20 17:16:32]

https://codereview.chromium.org/1900423002/diff/180001/src/heap/spaces.h
File src/heap/spaces.h (left):

https://codereview.chromium.org/1900423002/diff/180001/src/heap/spaces.h#oldc...
src/heap/spaces.h:571: bool is_valid() { return address() != NULL; }
Replaced with IsValid to not rely on calling a method when this == nullptr.
(-fsanitize=null)

[Michael Lippautz, 2016-04-20 17:37:01]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 17:37:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900423002/190013
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900423002/190013

[commit-bot: I haz the power, 2016-04-20 18:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 18:01:41]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-04-25 13:36:58]

lgtm

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h#newc...
src/heap/spaces.h:862: static Page* FromTopOrLimit(Address address) {
Naming nit: Maybe call it FromAllocationArea (or something like that) to keep it
more generic? Also fix comment after updating.

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h#newc...
src/heap/spaces.h:881: // Only works for addresses in pointer spaces, not code
space.
The comment is not true.

[Michael Lippautz, 2016-04-25 14:15:18]

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h#newc...
src/heap/spaces.h:862: static Page* FromTopOrLimit(Address address) {
On 2016/04/25 13:36:58, Hannes Payer wrote:
> Naming nit: Maybe call it FromAllocationArea (or something like that) to keep
it
> more generic? Also fix comment after updating.

Done: FromAllocationAreaAddress (to be in sync with FromAddress)

https://codereview.chromium.org/1900423002/diff/190013/src/heap/spaces.h#newc...
src/heap/spaces.h:881: // Only works for addresses in pointer spaces, not code
space.
On 2016/04/25 13:36:58, Hannes Payer wrote:
> The comment is not true.

Done.

[Michael Lippautz, 2016-04-25 14:22:52]

Patchset #9 (id:230001) has been deleted

[Michael Lippautz, 2016-04-25 14:23:02]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 14:23:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900423002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900423002/250001

[commit-bot: I haz the power, 2016-04-25 14:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 14:49:44]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-04-25 14:50:07]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-04-25 14:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1900423002/#ps250001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-04-25 14:50:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900423002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900423002/250001

[commit-bot: I haz the power, 2016-04-25 14:52:36]

Committed patchset #9 (id:250001)

[commit-bot: I haz the power, 2016-04-25 14:53:53]

Description was changed from

==========
[heap] Merge NewSpacePage into Page

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Merge NewSpacePage into Page

BUG=chromium:581412
LOG=N

Committed: https://crrev.com/4e8736da2da2281979cdb0e97a34fd490644bb3d
Cr-Commit-Position: refs/heads/master@{#35768}
==========

[commit-bot: I haz the power, 2016-04-25 14:53:54]

Patchset 9 (id:??) landed as
https://crrev.com/4e8736da2da2281979cdb0e97a34fd490644bb3d
Cr-Commit-Position: refs/heads/master@{#35768}