Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1900383002: [turbofan] Properly connect potentially throwing ToNumber to control chain. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly connect potentially throwing ToNumber to control chain. In JSTypedLowering we insert JSToNumber nodes for implicit type conversions, which can potentially throw (i.e. the input not statically known to be a plain primitive). R=jarin@chromium.org Committed: https://crrev.com/fc3ecad44b1964a52922830093e05b09949604c4 Cr-Commit-Position: refs/heads/master@{#35639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-20 04:11:04 UTC) #1
Benedikt Meurer
Hey Jaro, Simple fix, needed for proper JSToNumber lowering. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-20 04:11:56 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-20 04:58:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900383002/1
4 years, 8 months ago (2016-04-20 05:00:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 05:02:38 UTC) #6
nodir1
4 years, 8 months ago (2016-04-22 18:43:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc3ecad44b1964a52922830093e05b09949604c4
Cr-Commit-Position: refs/heads/master@{#35639}

Powered by Google App Engine
This is Rietveld 408576698