Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1900373003: Code Completion API fix of mistake in DartCompletionRequest (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code Completion API fix of mistake in DartCompletionRequest R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/55eac4da46aaa04049b716696254f507615631f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
4 years, 8 months ago (2016-04-20 22:04:14 UTC) #2
danrubel
LGTM
4 years, 8 months ago (2016-04-21 12:56:18 UTC) #3
jwren
4 years, 8 months ago (2016-04-21 17:05:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55eac4da46aaa04049b716696254f507615631f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698