Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1900373002: Add owners for c/b/resources/safe_browsing (Closed)

Created:
4 years, 8 months ago by Nathan Parker
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add owners for c/b/resources/safe_browsing BUG=596555 Committed: https://crrev.com/2fba55879acce722bb0175fadbdea00310bd8a90 Cr-Commit-Position: refs/heads/master@{#388566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + chrome/browser/resources/safe_browsing/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Nathan Parker
4 years, 8 months ago (2016-04-20 04:10:39 UTC) #2
Lei Zhang
lgtm, but probably not needed for the bug?
4 years, 8 months ago (2016-04-20 04:14:32 UTC) #3
Nathan Parker
There will be semi-regular updates to the asciipb, so it's helpful for the maintenance down ...
4 years, 8 months ago (2016-04-20 16:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900373002/1
4 years, 8 months ago (2016-04-20 16:15:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/124867) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-20 16:20:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900373002/1
4 years, 8 months ago (2016-04-20 20:10:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:20:45 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fba55879acce722bb0175fadbdea00310bd8a90
Cr-Commit-Position: refs/heads/master@{#388566}

Powered by Google App Engine
This is Rietveld 408576698