Add default EXE manifest to setup.exe

Add default EXE manifest to setup.exe

The gn built mini_installer was failing on Windows 10. This was
because the mini_installer was inadvertently launching Chrome when it
was not supposed to. This in turn was because setup.exe was missing its
manifest and therefore thought it was running on an earlier version of
Windows and therefore tried to pin Chrome's shortcut which on Windows 10
launches Chrome through a separate thread that runs inscrutable shell32
goop.

Messy problem, trivial fix.

BUG=604752
Committed: https://crrev.com/92d3af5151b4845066895b9448b42d33c4030438
Cr-Commit-Position: refs/heads/master@{#388579}

[brucedawson, 2016-04-20 18:14:02]

brucedawson@chromium.org changed reviewers:
+ grt@chromium.org

[brucedawson, 2016-04-20 18:14:03]

Simple fix to the mini_installer problems. PTAL. I've manually verified that
this gives setup.exe a manifest and that it fixes the problem of Chrome being
launched by mini_installer.

brettw@ - when default_exe_manifest is added we get
Microsoft.Windows.Common-Controls in the manifest as well, which is different
from the gyp version of the manifest. I assume that this is harmless and maybe
even desirable but don't actually know. Just mentioning it in case either of you
have thoughts on this.

[grt (UTC plus 2), 2016-04-20 18:28:11]

grt@chromium.org changed reviewers:
+ brettw@chromium.org

[grt (UTC plus 2), 2016-04-20 18:28:12]

+brettw for comment, though lgtm.

[brettw, 2016-04-20 19:04:13]

Gaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa...

LGTM

...aaaaaaaaaaaaaaaaaaaaaaaaa

[brucedawson, 2016-04-20 19:40:10]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-04-20 19:40:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900343005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900343005/1

[commit-bot: I haz the power, 2016-04-20 21:29:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:26:34]

Description was changed from

==========
Add default EXE manifest to setup.exe

The gn built mini_installer was failing on Windows 10. This was
because the mini_installer was inadvertently launching Chrome when it
was not supposed to. This in turn was because setup.exe was missing its
manifest and therefore thought it was running on an earlier version of
Windows and therefore tried to pin Chrome's shortcut which on Windows 10
launches Chrome through a separate thread that runs inscrutable shell32
goop.

Messy problem, trivial fix.

BUG=604752
==========

to

==========
Add default EXE manifest to setup.exe

The gn built mini_installer was failing on Windows 10. This was
because the mini_installer was inadvertently launching Chrome when it
was not supposed to. This in turn was because setup.exe was missing its
manifest and therefore thought it was running on an earlier version of
Windows and therefore tried to pin Chrome's shortcut which on Windows 10
launches Chrome through a separate thread that runs inscrutable shell32
goop.

Messy problem, trivial fix.

BUG=604752

Committed: https://crrev.com/92d3af5151b4845066895b9448b42d33c4030438
Cr-Commit-Position: refs/heads/master@{#388579}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:35]

Patchset 1 (id:??) landed as
https://crrev.com/92d3af5151b4845066895b9448b42d33c4030438
Cr-Commit-Position: refs/heads/master@{#388579}