Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/parsing/parser.h

Issue 1900343002: More accurately record an end position for default parameters in arrows (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: nikolaos comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSING_PARSER_H_ 5 #ifndef V8_PARSING_PARSER_H_
6 #define V8_PARSING_PARSER_H_ 6 #define V8_PARSING_PARSER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 523 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 FunctionKind kind = kNormalFunction); 534 FunctionKind kind = kNormalFunction);
535 535
536 V8_INLINE void AddFormalParameter(ParserFormalParameters* parameters, 536 V8_INLINE void AddFormalParameter(ParserFormalParameters* parameters,
537 Expression* pattern, 537 Expression* pattern,
538 Expression* initializer, 538 Expression* initializer,
539 int initializer_end_position, bool is_rest); 539 int initializer_end_position, bool is_rest);
540 V8_INLINE void DeclareFormalParameter( 540 V8_INLINE void DeclareFormalParameter(
541 Scope* scope, const ParserFormalParameters::Parameter& parameter, 541 Scope* scope, const ParserFormalParameters::Parameter& parameter,
542 Type::ExpressionClassifier* classifier); 542 Type::ExpressionClassifier* classifier);
543 void ParseArrowFunctionFormalParameters(ParserFormalParameters* parameters, 543 void ParseArrowFunctionFormalParameters(ParserFormalParameters* parameters,
544 Expression* params, 544 Expression* params, int end_pos,
545 const Scanner::Location& params_loc,
546 bool* ok); 545 bool* ok);
547 void ParseArrowFunctionFormalParameterList( 546 void ParseArrowFunctionFormalParameterList(
548 ParserFormalParameters* parameters, Expression* params, 547 ParserFormalParameters* parameters, Expression* params,
549 const Scanner::Location& params_loc, 548 const Scanner::Location& params_loc,
550 Scanner::Location* duplicate_loc, bool* ok); 549 Scanner::Location* duplicate_loc, bool* ok);
551 550
552 V8_INLINE DoExpression* ParseDoExpression(bool* ok); 551 V8_INLINE DoExpression* ParseDoExpression(bool* ok);
553 552
554 void ReindexLiterals(const ParserFormalParameters& parameters); 553 void ReindexLiterals(const ParserFormalParameters& parameters);
555 554
(...skipping 691 matching lines...) Expand 10 before | Expand all | Expand 10 after
1247 1246
1248 DoExpression* ParserTraits::ParseDoExpression(bool* ok) { 1247 DoExpression* ParserTraits::ParseDoExpression(bool* ok) {
1249 return parser_->ParseDoExpression(ok); 1248 return parser_->ParseDoExpression(ok);
1250 } 1249 }
1251 1250
1252 1251
1253 } // namespace internal 1252 } // namespace internal
1254 } // namespace v8 1253 } // namespace v8
1255 1254
1256 #endif // V8_PARSING_PARSER_H_ 1255 #endif // V8_PARSING_PARSER_H_
OLDNEW
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698