Rewriting loop in accessibility code to silence analyzer.

Rewriting loop in accessibility code to silence analyzer.

The VS static analyzer thought the code was a mistake by the author
(starting value less than that limit in a decreasing loop)
and judging by the comment, humans also find the loop non-trvial.

So make it more normal.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256086

[Daniel Bratell, 2014-03-07 17:12:01]

I'm not sure who owns the accessibility code, but this is code that a static
analyzer complained about so I thought it better to make the analyzer happy.

[Ben Goodger (Google), 2014-03-07 19:45:39]

On Fri, Mar 7, 2014 at 9:12 AM, <bratell@opera.com> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> I'm not sure who owns the accessibility code,


http://src.chromium.org/viewvc/chrome/trunk/src/ui/accessibility/OWNERS

:-)

-Ben

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Bratell, 2014-03-08 10:49:56]

On 2014/03/07 19:45:39, Ben Goodger (Google) wrote:
> On Fri, Mar 7, 2014 at 9:12 AM, <mailto:bratell@opera.com> wrote:
> 
> > Reviewers: Ben Goodger (Google),
> >
> > Message:
> > I'm not sure who owns the accessibility code,
> 
> 
> http://src.chromium.org/viewvc/chrome/trunk/src/ui/accessibility/OWNERS
> 

Oh, then why did git cl upload say:

** Presubmit Messages **
Missing OWNER reviewers for these files:
   .gitmodules
   ui\accessibility\ax_text_utils.cc

?

Anyway, thanks!

[Daniel Bratell, 2014-03-08 10:50:56]

On 2014/03/08 10:49:56, Daniel Bratell wrote:
> On 2014/03/07 19:45:39, Ben Goodger (Google) wrote:
> > On Fri, Mar 7, 2014 at 9:12 AM, <mailto:bratell@opera.com> wrote:
> > 
> > > Reviewers: Ben Goodger (Google),
> > >
> > > Message:
> > > I'm not sure who owns the accessibility code,
> > 
> > 
> > http://src.chromium.org/viewvc/chrome/trunk/src/ui/accessibility/OWNERS
> > 
> 
> Oh, then why did git cl upload say:
> 
> ** Presubmit Messages **
> Missing OWNER reviewers for these files:
>    .gitmodules
>    ui\accessibility\ax_text_utils.cc
> 
> ?
> 
> Anyway, thanks!

(And Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    ben@chromium.org)

[Daniel Bratell, 2014-03-08 10:51:25]

dmazzoni, can you please take a look and see if this change is worth doing (and
correct).

[dmazzoni, 2014-03-10 17:02:52]

lgtm

Makes sense, thanks.

[commit-bot: I haz the power, 2014-03-10 17:49:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/190033006/30001

[commit-bot: I haz the power, 2014-03-10 18:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 18:13:07]

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

[Daniel Bratell, 2014-03-10 19:51:52]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-03-10 19:53:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/190033006/30001

[commit-bot: I haz the power, 2014-03-10 21:43:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/190033006/30001

[commit-bot: I haz the power, 2014-03-10 22:22:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/190033006/30001

[commit-bot: I haz the power, 2014-03-10 23:40:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/190033006/30001

[commit-bot: I haz the power, 2014-03-11 00:49:23]

Change committed as 256086