Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chromeos/ime/component_extension_ime_manager.h

Issue 190033005: [IME] Removes the duplicated IMEs in chrome://settings/languages, and support async component IMEs … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try to make test green. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/component_extension_ime_manager.h
diff --git a/chromeos/ime/component_extension_ime_manager.h b/chromeos/ime/component_extension_ime_manager.h
index 8d7975820e9797501dc1b6661302e81ca339d2dc..fad81d3aa426b9da17c0d9a5db4b231352a634a6 100644
--- a/chromeos/ime/component_extension_ime_manager.h
+++ b/chromeos/ime/component_extension_ime_manager.h
@@ -66,7 +66,7 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
class Observer {
public:
// Called when the initialization is done.
- virtual void OnInitialized() = 0;
+ virtual void OnImeComponentExtensionInitialized() = 0;
};
ComponentExtensionIMEManager();
@@ -77,6 +77,9 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
// be called before using any other function.
void Initialize(scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate);
+ // Notifies the observers for the component extension IMEs are initialized.
+ void NotifyInitialized();
+
// Returns true if the initialization is done, otherwise returns false.
bool IsInitialized();
@@ -114,6 +117,9 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
// Returns all IME as InputMethodDescriptors.
input_method::InputMethodDescriptors GetAllIMEAsInputMethodDescriptor();
+ // Returns all XKB keyboard IME as InputMethodDescriptors.
+ input_method::InputMethodDescriptors GetXkbIMEAsInputMethodDescriptor();
+
void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer);
@@ -135,6 +141,8 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
bool is_initialized_;
+ bool was_initialization_notified_;
+
std::set<std::string> login_layout_set_;
DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManager);
« no previous file with comments | « chrome/test/data/extensions/api_test/input_method/background.js ('k') | chromeos/ime/component_extension_ime_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698