[IME] Removes the duplicated IMEs in chrome://settings/languages, and support async component IMEs …

chromeos/ime/component_extension_ime_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_
 #define CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_
 
 #include <set>
 
 #include "base/files/file_path.h"
@@ skipping 48 matching lines @@
   virtual bool Unload(const std::string& extension_id,
                       const base::FilePath& path) = 0;
 };
 
 // This class manages component extension input method.
 class CHROMEOS_EXPORT ComponentExtensionIMEManager {
  public:
   class Observer {
    public:
     // Called when the initialization is done.
     virtual void OnInitialized() = 0;

[Yuki, 2014/03/07 07:47:04]

This is not your fault, but this is a very bad name.
If possible, could you rename this to something more specific?  For example,
OnImeComponentExtensionInitialized().

It's too bad and confusing that NetworkScreenHandler::OnInitialized() overrides
this method.  NetworkScreenHandler::OnInitialized() looks like it's called when
NetworkScreenHandler is initialized.

There are 1 unittest and CrosLanguageOptionsHandler that override this method. 
So shouldn't be too much work.

[Shu Chen, 2014/03/07 08:24:09]

Done.

   };
 
   ComponentExtensionIMEManager();
   virtual ~ComponentExtensionIMEManager();
 
   // Initializes component extension manager. This function create internal
   // mapping between input method id and engine components. This function must
   // be called before using any other function.
   void Initialize(scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate);
 
+  // Notifies the observes for the component extension IMEs are initialized.

[Yuki, 2014/03/07 07:47:04]

typo: s/observes/observers/

[Shu Chen, 2014/03/07 08:24:09]

Done.

+  void NotifyInitialized();
+
   // Returns true if the initialization is done, otherwise returns false.
   bool IsInitialized();
 
   // Loads |input_method_id| component extension IME. This function returns true
   // on success. This function is safe to call multiple times. Returns false if
   // already corresponding component extension is loaded.
   bool LoadComponentExtensionIME(const std::string& input_method_id);
 
   // Unloads |input_method_id| component extension IME. This function returns
   // true on success. This function is safe to call multiple times. Returns
@@ skipping 17 matching lines @@
 
   // Returns localized description of |input_method_id|.
   std::string GetDescription(const std::string& input_method_id);
 
   // Returns list of input method id associated with |language|.
   std::vector<std::string> ListIMEByLanguage(const std::string& language);
 
   // Returns all IME as InputMethodDescriptors.
   input_method::InputMethodDescriptors GetAllIMEAsInputMethodDescriptor();
 
+  // Returns all XKB keyboard IME as InputMethodDescriptors.
+  input_method::InputMethodDescriptors GetXkbIMEAsInputMethodDescriptor();
+
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  private:
   // Finds ComponentExtensionIME and EngineDescription associated with
   // |input_method_id|. This function retruns true if it is found, otherwise
   // returns false. |out_extension| and |out_engine| can be NULL.
   bool FindEngineEntry(const std::string& input_method_id,
                        ComponentExtensionIME* out_extension,
                        ComponentExtensionEngine* out_engine);
 
   bool IsInLoginLayoutWhitelist(const std::vector<std::string>& layouts);
 
   scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate_;
 
   std::vector<ComponentExtensionIME> component_extension_imes_;
 
   ObserverList<Observer> observers_;
 
   bool is_initialized_;
 
   std::set<std::string> login_layout_set_;
 
   DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManager);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_IME_COMPONENT_EXTENSION_IME_MANAGER_H_