DelegatedFrameHost: Prevent FrameSubscriber captures if damage_rect is empty.

DelegatedFrameHost: Prevent FrameSubscriber captures if damage_rect is empty.

Resolves an issue where tab capture of "perfectly @24 FPS content" was
producing frames at ~26 FPS.  See bug for details.

BUG=604110
R=jbauman@chromium.org

Committed: https://crrev.com/757d6a28721ebf585c1b87433ab1bd81c9199fc3
Cr-Commit-Position: refs/heads/master@{#388358}

[miu, 2016-04-19 21:58:03]

miu@chromium.org changed reviewers:
+ sievers@chromium.org

[miu, 2016-04-19 21:58:04]

jbauman: PTAL.

sievers: Need RS OWNERS stamp, please.

[no sievers, 2016-04-19 23:07:55]

lgtm

[jbauman, 2016-04-19 23:11:24]

lgtm. I would have expected ShouldCaptureFrame to reject a frame with no damage
rect, but this works.

[miu, 2016-04-19 23:32:01]

On 2016/04/19 23:11:24, jbauman wrote:
> lgtm. I would have expected ShouldCaptureFrame to reject a frame with no
damage
> rect, but this works.

Perhaps it should.  There are other code paths that call it with an empty
damage_rect to mean "all of it."  I need to revisit them.

Thanks for the quick turnaround.

[miu, 2016-04-19 23:32:20]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2016-04-19 23:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900313002/1

[commit-bot: I haz the power, 2016-04-19 23:38:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:18:10]

Description was changed from

==========
DelegatedFrameHost: Prevent FrameSubscriber captures if damage_rect is empty.

Resolves an issue where tab capture of "perfectly @24 FPS content" was
producing frames at ~26 FPS.  See bug for details.

BUG=604110
R=jbauman@chromium.org
==========

to

==========
DelegatedFrameHost: Prevent FrameSubscriber captures if damage_rect is empty.

Resolves an issue where tab capture of "perfectly @24 FPS content" was
producing frames at ~26 FPS.  See bug for details.

BUG=604110
R=jbauman@chromium.org

Committed: https://crrev.com/757d6a28721ebf585c1b87433ab1bd81c9199fc3
Cr-Commit-Position: refs/heads/master@{#388358}
==========

[commit-bot: I haz the power, 2016-04-22 19:18:11]

Patchset 1 (id:??) landed as
https://crrev.com/757d6a28721ebf585c1b87433ab1bd81c9199fc3
Cr-Commit-Position: refs/heads/master@{#388358}