Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1900233007: [ImportantSites] Added feature for finch & about:flags (Closed)

Created:
4 years, 8 months ago by dmurph
Modified:
4 years, 8 months ago
Reviewers:
nyquist, motek.
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ImportantSites] Added feature for finch & about:flags This feature will enable an extra dialog in the CBD flow, where we allow users to exclude domains that we think are important to them from being cleared. See project here: http://goto/importantsites BUG=579763 Committed: https://crrev.com/f1e28c70ca36fc8439054bd27a660995a4c46be0 Cr-Commit-Position: refs/heads/master@{#388874}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dmurph
Hello! I'd like to add feature & flags for the new ImportantSites feature in the ...
4 years, 8 months ago (2016-04-21 00:04:43 UTC) #2
nyquist
lgtm, but bonus points for a little bit longer CL description so people don't have ...
4 years, 8 months ago (2016-04-21 17:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900233007/1
4 years, 8 months ago (2016-04-21 18:47:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/23091) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 18:51:48 UTC) #10
dmurph
Added a better CL description, and rebased. Thanks!
4 years, 8 months ago (2016-04-21 19:18:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900233007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900233007/20001
4 years, 8 months ago (2016-04-21 19:21:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 20:13:34 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:38:31 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1e28c70ca36fc8439054bd27a660995a4c46be0
Cr-Commit-Position: refs/heads/master@{#388874}

Powered by Google App Engine
This is Rietveld 408576698