Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1900233006: [Chromecast] Remove command-line switch to change the number of mixer output channels (Closed)

Created:
4 years, 8 months ago by kmackay
Modified:
4 years, 8 months ago
Reviewers:
tianyuwang1, halliwell
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Remove command-line switch to change the number of mixer output channels We don't need it. BUG= Committed: https://crrev.com/218d76aabe939d248caf4e5bfc0ff2752c06fb35 Cr-Commit-Position: refs/heads/master@{#389352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -77 lines) Patch
M chromecast/base/chromecast_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/base/chromecast_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 6 chunks +7 lines, -13 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chromecast/media/cma/decoder/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/decoder/cast_audio_decoder_linux.cc View 6 chunks +5 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kmackay
4 years, 8 months ago (2016-04-20 23:53:40 UTC) #2
halliwell
On 2016/04/20 23:53:40, kmackay wrote: nit, put [Chromecast] on front of description Otherwise lgtm
4 years, 8 months ago (2016-04-21 00:09:24 UTC) #3
tianyuwang1
lgtm lgtm Thanks for the clean up!
4 years, 8 months ago (2016-04-23 01:02:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900233006/1
4 years, 8 months ago (2016-04-23 02:22:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 03:20:47 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 03:22:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218d76aabe939d248caf4e5bfc0ff2752c06fb35
Cr-Commit-Position: refs/heads/master@{#389352}

Powered by Google App Engine
This is Rietveld 408576698