 Chromium Code Reviews
 Chromium Code Reviews Issue 1900223003:
  [tracing] Ignore tracing allocations in heap profiler  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1900223003:
  [tracing] Ignore tracing allocations in heap profiler  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: base/trace_event/trace_buffer.cc | 
| diff --git a/base/trace_event/trace_buffer.cc b/base/trace_event/trace_buffer.cc | 
| index b9f80b27b6924daa5f62874a4104d3f49ed0c915..3faa934b2467de8c499abb4a1682a04ec385d4c8 100644 | 
| --- a/base/trace_event/trace_buffer.cc | 
| +++ b/base/trace_event/trace_buffer.cc | 
| @@ -9,6 +9,7 @@ | 
| #include <vector> | 
| #include "base/macros.h" | 
| +#include "base/trace_event/malloc_dump_provider.h" | 
| #include "base/trace_event/trace_event_impl.h" | 
| namespace base { | 
| @@ -31,6 +32,7 @@ class TraceBufferRingBuffer : public TraceBuffer { | 
| } | 
| std::unique_ptr<TraceBufferChunk> GetChunk(size_t* index) override { | 
| + SCOPED_HEAP_PROFILER_IGNORE_MALLOC_EVENT; | 
| 
Primiano Tucci (use gerrit)
2016/04/20 16:34:57
I think you want to move this only to line 52 whic
 
ssid
2016/04/21 01:07:46
There is a chunks_.resize call too. When we can ca
 
Primiano Tucci (use gerrit)
2016/04/21 19:47:31
ahh right
 | 
| // Because the number of threads is much less than the number of chunks, | 
| // the queue should never be empty. | 
| DCHECK(!QueueIsEmpty()); |