X87: [turbofan] CodeGenerator: Frame setup refactoring.

X87: [turbofan] CodeGenerator: Frame setup refactoring.

  port 81a1530e6fb3f4382098f71c01ffe047ffd72afc (r35642)

  original commit message:
  Before frame elision, we finalized the frame shape when assembling the
  prologue, which is also when we prepared the frame (saving sp, etc).

  The frame finalization only needs to happen once, and happens to be
  actually a set of idempotent operations. With frame elision, the logic for
  frame finalization was happening every time we constructed the frame.
  Albeit idempotent operations, the code would become hard to maintain.

  This change separates frame shape finalization from frame
  construction. When constructing the CodeGenerator, we finalize the
  frame. Subsequent access is to a const Frame*.

  Also renamed AssemblePrologue to AssembleConstructFrame, as
  suggested in the frame elision CR.

  Separating frame setup gave the opportunity to do away with
  architecture-independent frame aligning (which is something just arm64
  cares about), and also with stack pointer setup (also arm64). Both of
  these happen now at frame finalization on arm64.

  additional message:
  This CL also removed the temporary workaround for CL #35139 (53d51c52f3754fe0e7decacba4277e58cf9fb5a4)

BUG=

Committed: https://crrev.com/7e88aa3d81bd1c219266862fdb19bee2e65a65f6
Cr-Commit-Position: refs/heads/master@{#35648}

[zhengxing.li, 2016-04-20 08:09:16]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, mtrofin@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-04-20 08:09:16]

PTAL, thanks!

[Weiliang, 2016-04-20 08:10:46]

lgtm

[zhengxing.li, 2016-04-20 08:12:20]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-04-20 08:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900213004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900213004/1

[commit-bot: I haz the power, 2016-04-20 08:51:36]

Committed patchset #1 (id:1)

[nodir1, 2016-04-22 18:43:49]

Description was changed from

==========
X87: [turbofan] CodeGenerator: Frame setup refactoring.

  port 81a1530e6fb3f4382098f71c01ffe047ffd72afc (r35642)

  original commit message:
  Before frame elision, we finalized the frame shape when assembling the
  prologue, which is also when we prepared the frame (saving sp, etc).

  The frame finalization only needs to happen once, and happens to be
  actually a set of idempotent operations. With frame elision, the logic for
  frame finalization was happening every time we constructed the frame.
  Albeit idempotent operations, the code would become hard to maintain.

  This change separates frame shape finalization from frame
  construction. When constructing the CodeGenerator, we finalize the
  frame. Subsequent access is to a const Frame*.

  Also renamed AssemblePrologue to AssembleConstructFrame, as
  suggested in the frame elision CR.

  Separating frame setup gave the opportunity to do away with
  architecture-independent frame aligning (which is something just arm64
  cares about), and also with stack pointer setup (also arm64). Both of
  these happen now at frame finalization on arm64.

  additional message:
  This CL also removed the temporary workaround for CL #35139
(53d51c52f3754fe0e7decacba4277e58cf9fb5a4)

BUG=
==========

to

==========
X87: [turbofan] CodeGenerator: Frame setup refactoring.

  port 81a1530e6fb3f4382098f71c01ffe047ffd72afc (r35642)

  original commit message:
  Before frame elision, we finalized the frame shape when assembling the
  prologue, which is also when we prepared the frame (saving sp, etc).

  The frame finalization only needs to happen once, and happens to be
  actually a set of idempotent operations. With frame elision, the logic for
  frame finalization was happening every time we constructed the frame.
  Albeit idempotent operations, the code would become hard to maintain.

  This change separates frame shape finalization from frame
  construction. When constructing the CodeGenerator, we finalize the
  frame. Subsequent access is to a const Frame*.

  Also renamed AssemblePrologue to AssembleConstructFrame, as
  suggested in the frame elision CR.

  Separating frame setup gave the opportunity to do away with
  architecture-independent frame aligning (which is something just arm64
  cares about), and also with stack pointer setup (also arm64). Both of
  these happen now at frame finalization on arm64.

  additional message:
  This CL also removed the temporary workaround for CL #35139
(53d51c52f3754fe0e7decacba4277e58cf9fb5a4)

BUG=

Committed: https://crrev.com/7e88aa3d81bd1c219266862fdb19bee2e65a65f6
Cr-Commit-Position: refs/heads/master@{#35648}
==========

[nodir1, 2016-04-22 18:43:50]

Patchset 1 (id:??) landed as
https://crrev.com/7e88aa3d81bd1c219266862fdb19bee2e65a65f6
Cr-Commit-Position: refs/heads/master@{#35648}