Issue 19002008: Revert "Remove dependencies on /media for iOS."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19002008: Revert "Remove dependencies on /media for iOS." (Closed)

Created:
7 years, 5 months ago by blundell

Modified:
7 years, 5 months ago

Reviewers:
bdibello

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Remove dependencies on /media for iOS." This reverts commit 5acb0a7605d1eec9220e0b7b3b663967fcf1e5ce. We need to stop media_unittests running on the iOS simulator bot before we can safely reland this CL. TBR=bdibello Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211411

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -20 lines)			Patch
M	build/all.gyp	View	4 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	4 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/content_common.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View	4 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/test/content_test_suite_base.cc	View	3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blundell

Committed patchset #1 manually as r211411 (presubmit successful).

7 years, 5 months ago (2013-07-12 16:49:28 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages