Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 19002002: Revert "Mixed content iframe checks should use top" (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Revert "Mixed content iframe checks should use top" This reverts commit 147d599fb3afbe23ef39073db6d63abb8d373036. This patch triggered an assertion in ChromeRenderViewObserver::allowRunningInsecureContent where the frame_gurl and origin_host differ. Also, it breaks almost all ReferrerPolicyTests - not sure that this is a good thing given that some pages rely on this behavior. BUG=244210 TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/originHeader/origin-header-for-https-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/referrer-policy-redirect-link-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/ssl/referer-301-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/ssl/referer-303-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-10 14:07:47 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r153895 (presubmit successful).
7 years, 5 months ago (2013-07-10 14:08:07 UTC) #2
abarth-chromium
What do you mean by "it breaks almost all ReferrerPolicyTests" ?
7 years, 5 months ago (2013-07-10 18:02:18 UTC) #3
abarth-chromium
I see. You mean referrer_policy_browsertest.cc
7 years, 5 months ago (2013-07-10 18:04:52 UTC) #4
jochen (gone - plz use gerrit)
On 2013/07/10 18:04:52, abarth wrote: > I see. You mean referrer_policy_browsertest.cc Right, and when I ...
7 years, 5 months ago (2013-07-10 18:08:24 UTC) #5
abarth-chromium
On 2013/07/10 18:08:24, jochen wrote: > On 2013/07/10 18:04:52, abarth wrote: > > I see. ...
7 years, 5 months ago (2013-07-10 18:21:57 UTC) #6
abarth-chromium
7 years, 5 months ago (2013-07-10 18:32:20 UTC) #7
Message was sent while issue was closed.
I've re-opened https://codereview.chromium.org/18104009/ and will continue the
discussion there.

Powered by Google App Engine
This is Rietveld 408576698