Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1900193002:
SkFontHost/FreeType/ToUnicode: add an assert (Closed)
|
Created:
4 years, 8 months ago by hal.canary Modified:
4 years, 8 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkFontHost/FreeType/ToUnicode: add an assert
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1900193002
Committed: https://skia.googlesource.com/skia/+/f8c74a1ef9acc65e62dc56526acc47c5143d84d8
Patch Set 1 #
Total comments: 3
Patch Set 2 : 2016-04-20 (Wednesday) 11:05:56 EDT #Messages
Total messages: 19 (9 generated)
Description was changed from ========== SkFontHost/FreeType/ToUnicode: add an assert ========== to ========== SkFontHost/FreeType/ToUnicode: add an assert GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== SkFontHost/FreeType/ToUnicode: add an assert GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkFontHost/FreeType/ToUnicode: add an assert GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900193002/1
halcanary@google.com changed reviewers: + bungeman@google.com
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1900193002/diff/1/src/ports/SkFontHost_FreeTy... File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.chromium.org/1900193002/diff/1/src/ports/SkFontHost_FreeTy... src/ports/SkFontHost_FreeType.cpp:448: unsigned arrayLength = SkToUInt(face->num_glyphs); This is a rather confusing name, since there is no array. This is also FT_Long, so we should just use that type. FT_Long numGlyphs = face->num_glyphs; https://codereview.chromium.org/1900193002/diff/1/src/ports/SkFontHost_FreeTy... src/ports/SkFontHost_FreeType.cpp:449: glyphToUnicode->setCount(SkToInt(arrayLength)); SkToInt is a good idea.
https://codereview.chromium.org/1900193002/diff/1/src/ports/SkFontHost_FreeTy... File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.chromium.org/1900193002/diff/1/src/ports/SkFontHost_FreeTy... src/ports/SkFontHost_FreeType.cpp:448: unsigned arrayLength = SkToUInt(face->num_glyphs); On 2016/04/19 17:59:14, bungeman1 wrote: > This is a rather confusing name, since there is no array. This is also FT_Long, > so we should just use that type. > > FT_Long numGlyphs = face->num_glyphs; Done.
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Why not, lgtm.
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900193002/20001
Message was sent while issue was closed.
Description was changed from ========== SkFontHost/FreeType/ToUnicode: add an assert GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkFontHost/FreeType/ToUnicode: add an assert GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/f8c74a1ef9acc65e62dc56526acc47c5143d84d8 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f8c74a1ef9acc65e62dc56526acc47c5143d84d8 |
