Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1900043003: [turbofan] Fix static TypeCache::Get call in access builder. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix static TypeCache::Get call in access builder. Committed: https://crrev.com/61e97fea42a696f5d9c160dd9cc3d84666cd009c Cr-Commit-Position: refs/heads/master@{#35638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/access-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-19 21:28:58 UTC) #2
Benedikt Meurer
Awesome, thanks for fixing. LGTM.
4 years, 8 months ago (2016-04-20 03:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900043003/1
4 years, 8 months ago (2016-04-20 03:50:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 03:52:40 UTC) #6
nodir1
4 years, 8 months ago (2016-04-22 18:43:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/61e97fea42a696f5d9c160dd9cc3d84666cd009c
Cr-Commit-Position: refs/heads/master@{#35638}

Powered by Google App Engine
This is Rietveld 408576698