Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1900033005: Simplify some CloudPrintProxy code. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify some CloudPrintProxy code. Also fix some typos. Committed: https://crrev.com/e9f7961923002d88991075185ea8662aae53602f Cr-Commit-Position: refs/heads/master@{#388601}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -66 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.h View 2 chunks +14 lines, -9 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 21 chunks +76 lines, -52 lines 0 comments Download
M pdf/document_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
4 years, 8 months ago (2016-04-20 21:45:07 UTC) #2
dschuyler
LGTM with optional suggestion. https://codereview.chromium.org/1900033005/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right): https://codereview.chromium.org/1900033005/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc#newcode67 chrome/service/cloud_print/cloud_print_proxy_backend.cc:67: // shutdown. will 'shutdown.' fit ...
4 years, 8 months ago (2016-04-20 22:00:47 UTC) #3
Lei Zhang
https://codereview.chromium.org/1900033005/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right): https://codereview.chromium.org/1900033005/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc#newcode67 chrome/service/cloud_print/cloud_print_proxy_backend.cc:67: // shutdown. On 2016/04/20 22:00:47, dschuyler wrote: > will ...
4 years, 8 months ago (2016-04-20 22:04:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900033005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900033005/20001
4 years, 8 months ago (2016-04-20 22:06:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 23:54:15 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:39 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e9f7961923002d88991075185ea8662aae53602f
Cr-Commit-Position: refs/heads/master@{#388601}

Powered by Google App Engine
This is Rietveld 408576698