Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1900033002: Revert of Devtools: Cut color picker off at bottom instead of the top (Closed)

Created:
4 years, 8 months ago by samli
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Devtools: Cut color picker off at bottom instead of the top (patchset #1 id:1 of https://codereview.chromium.org/1816933002/ ) Reason for revert: Breaks color picker with no easy fix: crbug.com/603811 Original issue's description: > Devtools: Cut color picker off at bottom instead of the top > > When there is insufficent vertical space, the color picker is cut off at > the top. This change fixes it at the top in these situations, allowing > better usability of the color picker in these states. > > BUG=572101 > > Committed: https://crrev.com/acc1963c73bc1e4dabf926d5f99d9323d2918016 > Cr-Commit-Position: refs/heads/master@{#386581} TBR=lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=572101 Committed: https://crrev.com/c1796dc4798fbc8eed3948b7277311cf9acf6145 Cr-Commit-Position: refs/heads/master@{#388127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/spectrum.css View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
samli
Created Revert of Devtools: Cut color picker off at bottom instead of the top
4 years, 8 months ago (2016-04-19 02:24:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900033002/1
4 years, 8 months ago (2016-04-19 02:24:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900033002/1
4 years, 8 months ago (2016-04-19 02:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900033002/1
4 years, 8 months ago (2016-04-19 03:01:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900033002/1
4 years, 8 months ago (2016-04-19 03:31:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 03:46:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 03:47:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1796dc4798fbc8eed3948b7277311cf9acf6145
Cr-Commit-Position: refs/heads/master@{#388127}

Powered by Google App Engine
This is Rietveld 408576698